Storybook stories for phone verification modal and verify account section#2115
Storybook stories for phone verification modal and verify account section#2115J-C-L wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mephistic
left a comment
There was a problem hiding this comment.
LGTM - one note is that I've noticed some of the newer stories (especially re: the Ballot Initiative work) are making actual Firebase calls from the Storybook app.
It looks like this PR also runs into this issue in the new pages/ProfilePage story - I'm seeing Firebase requests for publishedTestimony in the network logs. This doesn't technically break anything important, but it means we're making real network requests for our fake test IDs, which won't return useful test data.
I've got a separate PR up to start tackling that problem (#2125 will block these calls going forward). I'm fine merging this and waiting to address this until both these PRs are merged to see how well the new defaults just work. IIRC there was an older issue that tackled the testimonyDetail slice issue - I might try to dig that up to see if there's a separate fix that would be useful here.
Summary
This is a follow up to Commit 9dd240b for issue #2089.
This adds storybook stories for the phone verification modal (phone step, code step, and success step), the verify account section that will appear on the edit profile view profile pages when a user is logged in, and the view profile page.
Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)Steps to test/reproduce
Run storybook.
Visually inspect each of the 3 steps (phone step, code step, and success step).
a. Visually inspect the box.
b. Click on Resend link in the email section. You should see a "something went wrong" message because no user is logged in.
c. Click on Verify in the phone section and confirm that the verify phone modal comes up.
Confirm page looks as expected for viewing one's own profile. This should include the "verify account" section for a user that has not yet verified phone or email.
Confirm page looks as expected for viewing someone else's profile. This should not include the "verify account" section, or the settings/your testimonies/followed content buttons