Skip to content

Storybook stories for phone verification modal and verify account section#2115

Open
J-C-L wants to merge 3 commits into
codeforboston:mainfrom
J-C-L:phone-verification-frontend
Open

Storybook stories for phone verification modal and verify account section#2115
J-C-L wants to merge 3 commits into
codeforboston:mainfrom
J-C-L:phone-verification-frontend

Conversation

@J-C-L
Copy link
Copy Markdown
Collaborator

@J-C-L J-C-L commented May 5, 2026

Summary

This is a follow up to Commit 9dd240b for issue #2089.
This adds storybook stories for the phone verification modal (phone step, code step, and success step), the verify account section that will appear on the edit profile view profile pages when a user is logged in, and the view profile page.

Checklist

  • [ n/a ] On the frontend, I've made my strings translate-able.
  • [ YES ] If I've added shared components, I've added a storybook story.
  • [ n/a ] I've made pages responsive and look good on mobile.
  • [ n/a ] f I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Steps to test/reproduce

Run storybook.

  1. Navigate to organisms > PhoneVerificationModal.
    Visually inspect each of the 3 steps (phone step, code step, and success step).
  2. Navigate to organisms > VerifyAccountSection.
    a. Visually inspect the box.
    b. Click on Resend link in the email section. You should see a "something went wrong" message because no user is logged in.
    c. Click on Verify in the phone section and confirm that the verify phone modal comes up.
  3. Navigate to Pages > ProfilePage > Own Profile.
    Confirm page looks as expected for viewing one's own profile. This should include the "verify account" section for a user that has not yet verified phone or email.
  4. Navigate to Pages > ProfilePage > Another's Profile
    Confirm page looks as expected for viewing someone else's profile. This should not include the "verify account" section, or the settings/your testimonies/followed content buttons

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment May 5, 2026 7:41pm

Request Review

Copy link
Copy Markdown
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one note is that I've noticed some of the newer stories (especially re: the Ballot Initiative work) are making actual Firebase calls from the Storybook app.

It looks like this PR also runs into this issue in the new pages/ProfilePage story - I'm seeing Firebase requests for publishedTestimony in the network logs. This doesn't technically break anything important, but it means we're making real network requests for our fake test IDs, which won't return useful test data.

I've got a separate PR up to start tackling that problem (#2125 will block these calls going forward). I'm fine merging this and waiting to address this until both these PRs are merged to see how well the new defaults just work. IIRC there was an older issue that tackled the testimonyDetail slice issue - I might try to dig that up to see if there's a separate fix that would be useful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants