Skip to content

Fix Follow button silent failure for logged-out users #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slarson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Follow button silent failure for logged-out users #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions components/shared/FollowButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { StyledImage } from "components/ProfilePage/StyledProfileComponents"
import { useTranslation } from "next-i18next"
import { useRouter } from "next/router"
import { useEffect, useContext } from "react"
import { Button } from "react-bootstrap"
import { useAuth } from "../auth"
Expand All @@ -22,6 +23,7 @@ export const BaseFollowButton = ({

const { user } = useAuth()
const uid = user?.uid
const router = useRouter()

const { followStatus, setFollowStatus } = useContext(FollowContext)

Expand Down Expand Up @@ -52,6 +54,11 @@ export const BaseFollowButton = ({
) : null
const handleClick = (event: React.FormEvent<HTMLFormElement>) => {
event.preventDefault()
if (!uid) {
const currentPath = router.asPath
router.push(`/login?redirect=${encodeURIComponent(currentPath)}`)
return
}
isFollowing ? UnfollowClick() : FollowClick()
}

Expand Down
7 changes: 7 additions & 0 deletions components/testimony/TestimonyDetailPage/PolicyActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { formUrl } from "components/publish"
import { FC, ReactElement, useContext, useEffect } from "react"
import { useCurrentTestimonyDetails } from "./testimonyDetailSlice"
import { useTranslation } from "next-i18next"
import { useRouter } from "next/router"
import { useAuth } from "components/auth"
import { TopicQuery } from "components/shared/FollowingQueries"
import { StyledImage } from "components/ProfilePage/StyledProfileComponents"
Expand Down Expand Up @@ -39,6 +40,7 @@ export const PolicyActions: FC<React.PropsWithChildren<PolicyActionsProps>> = ({

const { user } = useAuth()
const uid = user?.uid
const router = useRouter()

const { followStatus, setFollowStatus } = useContext(FollowContext)

Expand Down Expand Up @@ -69,6 +71,11 @@ export const PolicyActions: FC<React.PropsWithChildren<PolicyActionsProps>> = ({
) : null
const handleClick = (event: React.MouseEvent<Element, MouseEvent>) => {
event.preventDefault()
if (!uid) {
const currentPath = router.asPath
router.push(`/login?redirect=${encodeURIComponent(currentPath)}`)
return
}
isFollowing ? UnfollowClick() : FollowClick()
}

Expand Down