Skip to content

Truncate bill summary to 1000 chars and add modal for longer summaries#2084

Merged
Mephistic merged 1 commit intocodeforboston:mainfrom
Mephistic:ballot-modal
Mar 24, 2026
Merged

Truncate bill summary to 1000 chars and add modal for longer summaries#2084
Mephistic merged 1 commit intocodeforboston:mainfrom
Mephistic:ballot-modal

Conversation

@Mephistic
Copy link
Collaborator

Summary

This PR just provides a slightly better experience for ballot initiative bills with longer summaries - we now truncate the summary to 1000 chars and add a modal for longer summaries (similar to the bill text modal).

Checklist

  • On the frontend, I've made my strings translate-able.
  • [N/A] If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • [N/A] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

TBD

Known issues

N/A

Steps to test/reproduce

  1. Go to a ballot initiative bill page with a short summary (like /bills/194/H5001) and confirm that there is no modal trigger
  2. Go to a ballot initiative bill page with a long summary (like /bills/194/H5010) and confirm that the modal triggers as expected.

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Mar 24, 2026 10:56pm

Request Review

@Mephistic
Copy link
Collaborator Author

Going to merge to move this along - post-merge feedback is always welcome

@Mephistic Mephistic merged commit 1b7099d into codeforboston:main Mar 24, 2026
8 checks passed
@Mephistic Mephistic deleted the ballot-modal branch March 24, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant