Fix debug flags defaulting to disabled on push-triggered runs - #164
Open
flufflycthu1u wants to merge 1 commit into
Open
Fix debug flags defaulting to disabled on push-triggered runs#164flufflycthu1u wants to merge 1 commit into
flufflycthu1u wants to merge 1 commit into
Conversation
GitHub Actions coerces null to 0 when compared against a boolean, so inputs.debugsources != false evaluated to false (not true) when inputs.debugsources was null on a push trigger, silently disabling --debugsources/--debugposters instead of preserving the old hardcoded behavior. Explicitly branch on github.event_name instead of relying on null/boolean coercion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchinputs fordebugsources/debugpostersand setDEBUG_SOURCES/DEBUG_POSTERSenv vars viainputs.debugsources != false, assumingundefined != falseistrueon push-triggered runs (noinputscontext).null→0,false→0, sonull != falseactually evaluates tofalse. Onpushruns this silently disabled both debug flags instead of preserving the previous hardcoded--debugsources --debugpostersbehavior.github.event_nameinstead of relying on null/boolean coercion, so push runs always debug andworkflow_dispatchruns respect the manual input.Test plan
.github/workflows/dev.ymlstill parses viayaml.safe_load--debugsources --debugpostersare applied (mock sources/posters used)workflow_dispatchwith both inputs set tofalseand confirm the flags are omitted (live API/posters used)🤖 Generated with Claude Code