Open
Conversation
KRRT7
force-pushed
the
refactor/benchmarks-to-dotcodeflash
branch
2 times, most recently
from
2abaa19 to
efac516
Compare
Move codeflash's own benchmarks to .codeflash/benchmarks/. Add auto-discovery of .codeflash/benchmarks/ in codeflash compare and benchmark mode -- when benchmarks-root is not explicitly configured, the CLI checks for .codeflash/benchmarks/ before erroring. Backwards compatible: users with existing benchmarks-root config are unaffected. Docs continue to show tests/benchmarks as the example path.
KRRT7
force-pushed
the
refactor/benchmarks-to-dotcodeflash
branch
from
efac516 to
ec14860
Compare
… lint errors Add .resolve() to TemporaryDirectory path to expand Windows 8.3 short paths (e.g. RUNNER~1) to canonical long form, fixing test_pickle_patcher failures on Windows CI. Also add missing return type annotations and noqa suppressions for benchmark test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/benchmarks/to.codeflash/benchmarks/as the new standard location for benchmark tests.codeflash/benchmarks/incodeflash compareand--benchmarkmode whenbenchmarks-rootis not explicitly configuredbenchmarks-rootconfig are unaffected, docs unchangedChanges
git mv tests/benchmarks/ .codeflash/benchmarks/— 7 benchmark files movedcmd_compare.py: fallback to.codeflash/benchmarks/whenbenchmarks_rootnot in configcli.py: same fallback in--benchmarkmodeVerified
benchmarks-root)