Skip to content

⚡️ Speed up function collect_existing_class_names by 109% in PR #1660 (unstructured-inference) #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claude merged 2 commits into from
Mar 16, 2026
Merged

⚡️ Speed up function collect_existing_class_names by 109% in PR #1660 (unstructured-inference) #1845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3994f25
Optimize collect_existing_class_names
codeflash-ai[bot] Mar 16, 2026
a508ef6
fix: add explicit list[ast.AST] type annotation for stack in collect_…
github-actions[bot] Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 9 additions & 22 deletions codeflash/languages/python/context/code_context_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def _parse_and_collect_imports(code_context: CodeStringsMarkdown) -> tuple[ast.M

def collect_existing_class_names(tree: ast.Module) -> set[str]:
class_names = set()
stack = [tree]
stack: list[ast.AST] = [tree]

while stack:
node = stack.pop()
Expand All @@ -586,27 +586,14 @@ def collect_existing_class_names(tree: ast.Module) -> set[str]:
class_names.add(node.name)

# Only traverse nodes that can contain ClassDef nodes
if isinstance(
node,
(
ast.Module,
ast.ClassDef,
ast.FunctionDef,
ast.AsyncFunctionDef,
ast.If,
ast.For,
ast.AsyncFor,
ast.While,
ast.With,
ast.AsyncWith,
ast.Try,
ast.ExceptHandler,
),
):
stack.extend(getattr(node, "body", []))
stack.extend(getattr(node, "orelse", []))
stack.extend(getattr(node, "finalbody", []))
stack.extend(getattr(node, "handlers", []))
if hasattr(node, "body"):
stack.extend(node.body)
if hasattr(node, "orelse"):
stack.extend(node.orelse)
if hasattr(node, "finalbody"):
stack.extend(node.finalbody)
if hasattr(node, "handlers"):
stack.extend(node.handlers)

return class_names

Expand Down
Loading