FIX: --no-gen-tests Flag Causes Path Resolution Error with Module-Root #1086
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss-platform compatibility. Remove redundant path matching logic and enhance logging in parse_test_xml for better debugging of test type registration issues.
mashraf-222
requested review from
HeshamHM28,
aseembits93 and
mohammedahmed18
aseembits93
reviewed
Jan 16, 2026
| test_file | ||
| for test_file in self.test_files | ||
| if test_file.original_file_path is not None | ||
| and normalized == self._normalize_path_for_comparison(test_file.original_file_path) |
Contributor
There was a problem hiding this comment.
can refactor self._normalize_path_for_comparison(test_file.original_file_path) out for better readability
aseembits93
reviewed
Jan 16, 2026
| if normalized == self._normalize_path_for_comparison(test_file.instrumented_behavior_file_path) | ||
| or ( | ||
| test_file.benchmarking_file_path is not None | ||
| and normalized == self._normalize_path_for_comparison(test_file.benchmarking_file_path) |
Contributor
There was a problem hiding this comment.
same feedback as previous comment
Contributor
⚡️ Codeflash found optimizations for this PR📄 702% (7.02x) speedup for
|
Contributor
⚡️ Codeflash found optimizations for this PR📄 73% (0.73x) speedup for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle missing test file registration gracefully with improved path matching
Path normalization: Added a helper that normalizes paths before comparison:
Error handling: Replaced the assertion with a warning that:
Changes
models.py: Added_normalize_path_for_comparison()and updated path comparison methods to use itparse_test_output.py: Replaced assertion with warning and continueImpact
Fixes the crash and improves robustness when test file paths don't match exactly.