Fix backfillReportingChannel to actually resolve channel by name - #12
Draft
augmentcode[bot] wants to merge 1 commit into
Draft
Fix backfillReportingChannel to actually resolve channel by name#12augmentcode[bot] wants to merge 1 commit into
augmentcode[bot] wants to merge 1 commit into
Conversation
resolveSlackChannelId previously just echoed back whatever configuredChannelId was passed in, so the script could never populate Event.slackReportingChannelId for events that didn't already have one, and the --channel flag was silently ignored. - resolveSlackChannelId now looks up the channel by name via findSlackChannelByName when no configured ID is present, and returns its id. - backfillReportingChannel.ts passes channelName through, and passes null instead of the existing value when --force is set so lookups can overwrite a stale configured ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveSlackChannelIdwas reduced to a pass-through in #11, sobackfillReportingChannel.tscould never populateEvent.slackReportingChannelIdfor an event that didn't already have one, and its--channel=flag was silently ignored.resolveSlackChannelIdnow looks up the channel by name viafindSlackChannelByNamewhen no configured ID is passed in, returning its id.backfillReportingChannel.tspasseschannelNamethrough, and passesnullinstead of the existing value when--forceis set so a stale configured ID can be re-resolved and overwritten.