Skip to content

perf(worker): Batch fetch testruns for flake processing#867

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/batch-flake-testruns-EGOppY
Open

perf(worker): Batch fetch testruns for flake processing#867
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/batch-flake-testruns-EGOppY

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 20, 2026

Fixes WORKER-Y91. The issue was that: Processing flakes for a repository results in an N+1 query, fetching testruns individually for each upload, causing task timeouts.

  • Introduced get_testruns_for_uploads to fetch testruns for multiple uploads in a single batched query.
  • Grouped fetched testruns by upload ID in memory using defaultdict.
  • Modified process_single_upload to accept pre-fetched testruns instead of an upload object.
  • Updated process_flakes_for_commit to utilize the new batched fetching mechanism, significantly reducing database queries.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13566081

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Moderate risk because it changes the flake-processing query pattern and refactors process_single_upload’s inputs; correctness depends on grouping testruns by upload_id and handling uploads with no testruns.

Overview
Reduces N+1 DB queries in flake processing by batching testrun retrieval across all relevant uploads for a commit.

Replaces per-upload testrun queries with get_testruns_for_uploads(upload_ids) (single upload_id__in query) and updates process_single_upload to accept pre-fetched testruns; process_flakes_for_commit now preloads and groups testruns in-memory via defaultdict before processing each upload.

Reviewed by Cursor Bugbot for commit 53ddcdd. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (53ddcdd).
⚠️ Report is 32 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1307     1307           
  Lines       48017    48023    +6     
  Branches     1636     1636           
=======================================
+ Hits        44299    44305    +6     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.53% <16.66%> (-0.02%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant