Skip to content

fix: align Node.js engines with bundler-plugin-core (>=20)#327

Merged
thomasrockhu-codecov merged 1 commit intomainfrom
fix/align-node-engines-20
Apr 10, 2026
Merged

fix: align Node.js engines with bundler-plugin-core (>=20)#327
thomasrockhu-codecov merged 1 commit intomainfrom
fix/align-node-engines-20

Conversation

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Apr 10, 2026

Summary

@codecov/bundler-plugin-core already declared engines.node: >=20.0.0 after the @actions/* v3/v9 bump, but published consumer packages and the monorepo root still advertised >=18.0.0. That mismatch was misleading for engines-strict installs and did not match supported runtime policy.

Changes

  • Set engines.node to >=20.0.0 on the root package.json and on every published package under packages/* that previously required Node 18 (all plugins plus bundle-analyzer; bundler-plugin-core was already >=20).
  • Update NODE_VERSION_RANGE in checkNodeVersion.ts to >=20.0.0 so the runtime warning matches package.json.

Notes

  • @actions/core and @actions/github remain bundled into core’s dist; this change is about accurate support metadata and consistent version checks, not ESM resolution at load time.

Made with Cursor

@thomasrockhu-codecov
fix: align Node.js engines with bundler-plugin-core (>=20)
5afa699 
Set engines.node to >=20.0.0 on all published packages that depend on
@codecov/bundler-plugin-core and on the monorepo root so metadata matches
the supported runtime.

Update checkNodeVersion() to require Node 20+ so runtime warnings match
package.json engines.

Made-with: Cursor
@sentry
Copy link
Copy Markdown

sentry bot commented Apr 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.74%. Comparing base (59a022d) to head (5afa699).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../bundler-plugin-core/src/utils/checkNodeVersion.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Plugin core 98.05% <0.00%> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../bundler-plugin-core/src/utils/checkNodeVersion.ts 0.00% 1 Missing ⚠️
Components Coverage Δ
Plugin core 98.05% <0.00%> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

📢 Thoughts on this report? Let us know!

@sentry
Copy link
Copy Markdown

sentry bot commented Apr 10, 2026 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 63 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/remix-vite-plugin-esm 3.02kB 2.06kB (215.05%) ⬆️
@codecov/bundler-plugin-core-cjs 1.55MB -1 bytes (-0.0%) ⬇️
@codecov/rollup-plugin-esm 1.3kB -5.11kB (-79.7%) ⬇️
@codecov/sveltekit-plugin-esm 891 bytes -2.13kB (-70.56%) ⬇️
@codecov/example-sveltekit-app-client-esm 727.67kB -2 bytes (-0.0%) ⬇️
@codecov/example-sveltekit-app-server-esm 984.06kB -1 bytes (-0.0%) ⬇️
@codecov/nextjs-webpack-plugin-esm 4.86kB 3.74kB (336.0%) ⬆️
@codecov/bundle-analyzer-esm 6.9kB 3.79kB (122.05%) ⬆️
@codecov/astro-plugin-esm 862 bytes -2.41kB (-73.62%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/remix-vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.02kB 3.02kB 100.0% 🚀
index.d.mts (Deleted) -957 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/knkMOEKYXpDnjf4IRNJh3/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/knkMOEKYXpDnjf4IRNJh3/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/WBH78tz8jnbqgktIJpPXN/_buildManifest.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/WBH78tz8jnbqgktIJpPXN/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 3.45kB 3.45kB 100.0% 🚀
index.d.ts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 1.24kB 1.24kB 100.0% 🚀
index.d.mts (Deleted) -1.24kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs -1 bytes 1.55MB -0.0%

Files in index.cjs:

  • ./src/utils/checkNodeVersion.ts → Total Size: 389 bytes
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 862 bytes 862 bytes 100.0% 🚀
index.mjs (Deleted) -3.27kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/sveltekit-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 891 bytes 891 bytes 100.0% 🚀
index.mjs (Deleted) -3.03kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 14.67kB 14.67kB 100.0% 🚀
index.d.ts (Deleted) -14.67kB 0 bytes -100.0% 🗑️

Files in index.d.mts:

  • ./src/utils/checkNodeVersion.ts → Total Size: 85 bytes
view changes for bundle: @codecov/nextjs-webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 4.86kB 4.86kB 100.0% 🚀
index.d.ts (Deleted) -1.11kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-sveltekit-app-client-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_app/immutable/chunks/entry.*.js -2 bytes 31.45kB -0.01%
view changes for bundle: @codecov/example-sveltekit-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/internal.js -1 bytes 18.48kB -0.01%
view changes for bundle: @codecov/example-astro-5-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_REFlfVAL.mjs (New) 3.37kB 3.37kB 100.0% 🚀
manifest_2gfFOayG.mjs (Deleted) -3.37kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.92kB 3.92kB 100.0% 🚀
cli.mjs (New) 2.98kB 2.98kB 100.0% 🚀
index.d.ts (Deleted) -2.77kB 0 bytes -100.0% 🗑️
cli.d.ts (Deleted) -342 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/rollup-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 1.3kB 1.3kB 100.0% 🚀
index.mjs (Deleted) -6.41kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/temIfApx0e4Ul84xqiNK6/_buildManifest.js (New) 543 bytes 543 bytes 100.0% 🚀
static/temIfApx0e4Ul84xqiNK6/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XpwpWwaqMa-*.js (Deleted) -543 bytes 0 bytes -100.0% 🗑️
static/XpwpWwaqMa-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_BD9Zzqg5.mjs (New) 3.34kB 3.34kB 100.0% 🚀
manifest_BZ_hyHBv.mjs (Deleted) -3.34kB 0 bytes -100.0% 🗑️

@thomasrockhu-codecov thomasrockhu-codecov merged commit d9e5655 into main Apr 10, 2026
70 of 72 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the fix/align-node-engines-20 branch April 10, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-ford-codecov jason-ford-codecov jason-ford-codecov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomasrockhu-codecov @jason-ford-codecov