chore(integration-tests): bump Rollup 3 test alias to 3.30.0#326
Open
thomasrockhu-codecov wants to merge 2 commits intomainfrom
Open
chore(integration-tests): bump Rollup 3 test alias to 3.30.0#326thomasrockhu-codecov wants to merge 2 commits intomainfrom
thomasrockhu-codecov wants to merge 2 commits intomainfrom
Conversation
Update the integration-tests rollupV3 alias from 3.29.5 to 3.30.0 and refresh pnpm-lock.yaml. Regenerate Rollup v3 bundle-stats snapshots so reported bundler version and output hashes match the new release. Rollup 3.30.0 rejects output paths that escape the output directory; builds that relied on emitting outside the output root may need config changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know! |
Add root pnpm overrides so Rollup 3.29.4 and 3.29.5 resolve to 3.30.0 (unbuild, Vite 4, and related trees). Refresh the lockfile. Update Vite bundle-stats snapshots so bundler.version matches Vite 4's Rollup after the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollupV3alias torollup@3.30.0(was3.29.5) and refreshpnpm-lock.yaml.bundler.versionand output filenames match the new Rollup release.unbuild@v2calls forrollup@^3.29.4which defaults to3.29.4. Pushing tounbuild@v3+will removerollup@v3Notes for consumers
@codecov/rollup-pluginalready peersrollup3.x || 4.x; no plugin change is required.Rollup 3.30.0 throws if emitted asset paths would escape the configured output directory. Projects that relied on writing outside
output.dirmay need to adjustentryFileNames/chunkFileNames/assetFileNamesor plugins.Testing
bun test fixtures/generate-bundle-stats/rollup/(with the integration test API on port 8000) passes against the updated snapshots.Made with Cursor