fix: eliminate flaky address presenter test due to unescaped HTML entities#2674
Open
mroderick wants to merge 1 commit into
Open
fix: eliminate flaky address presenter test due to unescaped HTML entities#2674mroderick wants to merge 1 commit into
mroderick wants to merge 1 commit into
Conversation
Collaborator
Author
|
This is blocked by #2675 |
… spec The test constructs an expected string from Faker-generated city names, which can contain apostrophes (e.g. O'Connerstad). ERB::Util.html_escape escapes ' to ', but the expected value used raw characters, making the test pass or fail depending on which random city Faker returns. Wrap each component in ERB::Util.html_escape to match the presenter's behaviour, eliminating the flake.
mroderick
force-pushed
the
fix/flaky-address-presenter-test
branch
from
61343bc to
d7060a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
AddressPresenter#to_htmlspec builds an expected string from Faker-generated data. Faker cities can contain apostrophes (e.g.O'Connerstad), andERB::Util.html_escapeescapes'to'. The expected string used raw characters, so the test passed or failed depending on which random city Faker returned — a classic flake.Fix
Wrap each component in
ERB::Util.html_escapewhen building the expected value, matching what the presenter does internally.Verification
Ran the test with 12 different seeds (including the CI seed
32568). All pass.