chore(deps): bump premailer to ~> 1.26 to fix deprecation warnings#2616
Merged
Conversation
mroderick
force-pushed
the
chore/upgrade-premailer
branch
from
ffb7f53 to
747d5dc
Compare
Updates premailer from 1.21.0 to 1.29.0 via bundle update. This eliminates deprecation warnings in test output: warning: [DEPRECATION] positional arguments are deprecated use keyword instead. Also updates transitive dependencies: - css_parser: 1.14.0 → 2.2.0 - htmlentities: 4.3.4 → 4.4.2
mroderick
force-pushed
the
chore/upgrade-premailer
branch
from
747d5dc to
8c8751d
Compare
gnclmorais
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates premailer from 1.21.0 to 1.29.0 via bundle update.
Changes
Why
The old premailer version (1.21.0) was causing deprecation warnings in test output:
This was fixed in premailer 1.26.0+, which updated to use css_parser with keyword arguments.
Files Changed
Only - no changes to required.
Testing
Maler tests pass successfully:
Randomized with seed 49267
.......
Finished in 1.52 seconds (files took 3.47 seconds to load)
7 examples, 0 failures
Randomized with seed 49267