Skip to content

Fix: Flaky tests in CI #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mroderick wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

Fix: Flaky tests in CI #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/features/admin/manage_workshop_attendances_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

scenario 'can remove a member from the attendee list' do
visit admin_workshop_path(workshop)
expect(page).to have_css('.cancel_attendance', wait: 5)
find('.cancel_attendance').click

expect(page).to have_content('0 are attending as students')
Expand Down
6 changes: 4 additions & 2 deletions spec/features/listing_coaches_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
RSpec.feature 'when visiting the coaches page', type: :feature do
scenario 'I can see the most active coaches' do
coach = Fabricate(:attended_coach).member
# Use a past workshop date in the current year to ensure the coach is counted
workshop = Fabricate(:workshop, date_and_time: Time.zone.today.beginning_of_year + 1.month)
coach = Fabricate(:attended_coach, workshop: workshop).member
visit coaches_path
expect(page).to have_content coach.name
expect(page).to have_content(coach.name, wait: 5)
end

scenario 'I can see the top coaches by year' do
Expand Down