drop runtime feature#951
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the “runtime features” concept from the runtime status domain (DB + Rails model/service) and from the GraphQL API/docs, per Issue #935.
Changes:
- Drop
runtime_featurestable and remove theRuntimeFeaturemodel/policy plus associated factories and specs. - Remove runtime feature handling from
Runtimes::Grpc::RuntimeStatusUpdateServiceand related gRPC request specs. - Remove GraphQL
RuntimeFeaturetype/fields and update GraphQL docs/error-code docs accordingly.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/requests/grpc/sagittarius/runtime_status_service_spec.rb | Removes feature payload/assertions from gRPC runtime status update tests |
| spec/models/runtime_feature_spec.rb | Deletes model spec for removed RuntimeFeature |
| spec/graphql/types/runtime_status_type_spec.rb | Updates GraphQL type spec to stop querying runtimeFeatures |
| spec/factories/runtime_status.rb | Removes runtime_features association setup from factory |
| spec/factories/runtime_features.rb | Deletes factory for removed RuntimeFeature |
| docs/graphql/scalar/runtimefeatureid.md | Removes RuntimeFeature scalar doc |
| docs/graphql/object/runtimestatus.md | Removes runtimeFeatures field from RuntimeStatus docs |
| docs/graphql/object/runtimefeature.md | Removes RuntimeFeature object doc |
| docs/graphql/enum/errorcodeenum.md | Removes INVALID_RUNTIME_FEATURE from docs |
| db/structure.sql | Removes runtime_features table/sequence/index/FK from DB structure |
| db/schema_migrations/20260501171605 | Adds migration checksum entry for new migration |
| db/migrate/20260501171605_drop_runtime_features.rb | Adds migration to drop runtime_features table |
| app/services/runtimes/grpc/runtime_status_update_service.rb | Removes runtime feature update logic from status update service |
| app/services/error_code.rb | Removes invalid_runtime_feature error code |
| app/policies/runtime_feature_policy.rb | Deletes policy for removed model |
| app/models/runtime_status.rb | Removes has_many :runtime_features association |
| app/models/runtime_feature.rb | Deletes the RuntimeFeature model |
| app/graphql/types/runtime_status_type.rb | Removes runtime_features field from GraphQL RuntimeStatus type |
| app/graphql/types/runtime_feature_type.rb | Deletes GraphQL RuntimeFeature type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def change | ||
| drop_table :runtime_features do |t| | ||
| t.references :runtime_status, null: false, | ||
| foreign_key: { to_table: :runtime_statuses, on_delete: :cascade } |
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2494792326 Status: Passed Job summariesrspec: [cloud]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14184261915/artifacts/tmp/coverage/index.html rspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14184261914/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14184261913/artifacts/tmp/coverage/index.html docs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14184271024/artifacts/out/index.html rubocop772 files inspected, no offenses detected |
Resolves: #935