Skip to content

Fix problems with flow updates #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taucher2003 merged 1 commit into from
Feb 18, 2026
Merged

Fix problems with flow updates #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/node_parameter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,5 @@ def only_one_value_present

def destroy_value_objects
reference_value.destroy if reference_value.present?
function_value.destroy if function_value.present?
end
end
4 changes: 3 additions & 1 deletion app/services/namespaces/projects/flows/update_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def update_settings(t)
flow_setting = flow.flow_settings.find_or_initialize_by(flow_setting_id: setting.flow_setting_identifier)
flow_setting.object = setting.value

next if flow_setting.valid?
next if flow_setting.save

t.rollback_and_return! ServiceResponse.error(
message: 'Invalid flow settings',
Expand Down Expand Up @@ -198,6 +198,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
db_parameters[index].function_value = node[:node]
else
db_parameters[index].function_value&.destroy
db_parameters[index].function_value = nil
end

if parameter.value.reference_value.present?
Expand Down Expand Up @@ -228,6 +229,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
)
else
db_parameters[index].reference_value&.destroy
db_parameters[index].reference_value = nil
end

next if db_parameters[index].valid?
Expand Down