Conversation
StoreUpdater was rendered after GraphView, so on remount its cleanup (reset) and repopulation effects fired after GraphView's subtree effects. Custom nodes reading the store in their effects would see empty nodes/nodeLookup/edges during this window. Move StoreUpdater before GraphView so its effects run first, and switch to useIsomorphicLayoutEffect so the store is repopulated before any child useEffect or useLayoutEffect fires.
Reset spy history before clicking remount so the post-remount assertion only checks calls from the fresh mount, not pre-remount calls that trivially pass.
This improves the DX in cases like this:
const NODES: BuiltInNode[] = [
// ~~~~~~~~~~~~~
// TS error here currently, because these nodes
// don't explicitly set `type: "default"`
{ id: "1", position: { x: 0, y: 0 }, data: { label: "Node 1" } },
{ id: "2", position: { x: 100, y: 100 }, data: { label: "Node 2" } },
];
Explicitly allow missing `type` field in BuiltInNode type definition
…remount fix(react): prevent empty store during ReactFlow remount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )