Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-lamps-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@xyflow/react': patch
---

Ensure visual nodes selection state is cleared when zero selected nodes remain in the flow
25 changes: 21 additions & 4 deletions packages/react/src/store/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,16 @@ const createStore = ({
zIndexMode,
}),
setNodes: (nodes: Node[]) => {
const { nodeLookup, parentLookup, nodeOrigin, elevateNodesOnSelect, fitViewQueued, zIndexMode } = get();
const {
nodeLookup,
parentLookup,
nodeOrigin,
elevateNodesOnSelect,
fitViewQueued,
zIndexMode,
nodesSelectionActive,
} = get();

/*
* setNodes() is called exclusively in response to user actions:
* - either when the `<ReactFlow nodes>` prop is updated in the controlled ReactFlow setup,
Expand All @@ -107,19 +116,27 @@ const createStore = ({
* relevant for internal React Flow operations.
*/

const nodesInitialized = adoptUserNodes(nodes, nodeLookup, parentLookup, {
const { nodesInitialized, hasSelectedNodes } = adoptUserNodes(nodes, nodeLookup, parentLookup, {
nodeOrigin,
nodeExtent,
elevateNodesOnSelect,
checkEquality: true,
zIndexMode,
});

const nextNodesSelectionActive = nodesSelectionActive && hasSelectedNodes;

if (fitViewQueued && nodesInitialized) {
resolveFitView();
set({ nodes, nodesInitialized, fitViewQueued: false, fitViewOptions: undefined });
set({
nodes,
nodesInitialized,
fitViewQueued: false,
fitViewOptions: undefined,
nodesSelectionActive: nextNodesSelectionActive
});
} else {
set({ nodes, nodesInitialized });
set({ nodes, nodesInitialized, nodesSelectionActive: nextNodesSelectionActive });
}
},
setEdges: (edges: Edge[]) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/store/initialState.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const getInitialState = ({
const storeNodeExtent = nodeExtent ?? infiniteExtent;

updateConnectionLookup(connectionLookup, edgeLookup, storeEdges);
const nodesInitialized = adoptUserNodes(storeNodes, nodeLookup, parentLookup, {
const { nodesInitialized } = adoptUserNodes(storeNodes, nodeLookup, parentLookup, {
nodeOrigin: storeNodeOrigin,
nodeExtent: storeNodeExtent,
zIndexMode,
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/src/lib/store/initial-store.svelte.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function getInitialStore<NodeType extends Node = Node, EdgeType extends E
zIndexMode = $state.raw<ZIndexMode>(signals.props.zIndexMode ?? 'basic');

nodesInitialized: boolean = $derived.by(() => {
const nodesInitialized = adoptUserNodes(signals.nodes, this.nodeLookup, this.parentLookup, {
const { nodesInitialized } = adoptUserNodes(signals.nodes, this.nodeLookup, this.parentLookup, {
nodeExtent: this.nodeExtent,
nodeOrigin: this.nodeOrigin,
elevateNodesOnSelect: signals.props.elevateNodesOnSelect ?? true,
Expand Down
12 changes: 10 additions & 2 deletions packages/system/src/utils/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,24 @@ export function isManualZIndexMode(zIndexMode?: ZIndexMode): boolean {
return zIndexMode === 'manual';
}

type AdoptUserNodesReturn = {
nodesInitialized: boolean;
hasSelectedNodes: boolean;
};

export function adoptUserNodes<NodeType extends NodeBase>(
nodes: NodeType[],
nodeLookup: NodeLookup<InternalNodeBase<NodeType>>,
parentLookup: ParentLookup<InternalNodeBase<NodeType>>,
options: UpdateNodesOptions<NodeType> = {}
): boolean {
): AdoptUserNodesReturn {
const _options = mergeObjects(adoptUserNodesDefaultOptions, options);
const rootParentIndex = { i: 0 };
const tmpLookup = new Map(nodeLookup);
const selectedNodeZ: number =
_options?.elevateNodesOnSelect && !isManualZIndexMode(_options.zIndexMode) ? SELECTED_NODE_Z : 0;
let nodesInitialized = nodes.length > 0;
let hasSelectedNodes = false;

nodeLookup.clear();
parentLookup.clear();
Expand Down Expand Up @@ -178,9 +184,11 @@ export function adoptUserNodes<NodeType extends NodeBase>(
if (userNode.parentId) {
updateChildNode(internalNode, nodeLookup, parentLookup, options, rootParentIndex);
}

hasSelectedNodes ||= userNode.selected ?? false;
}

return nodesInitialized;
return { nodesInitialized, hasSelectedNodes };
}

function updateParentLookup<NodeType extends NodeBase>(
Expand Down
Loading