[pull] main from ueberdosis:main#97
Merged
Merged
Conversation
#7848) * fix: properly handle inline nodes with text content during deleteSelection The selection is now expanded to include entire inline node boundaries when deleting, preventing incorrect collapse of inline text nodes. Added tests for various deletion scenarios including empty selections, text selections, cross-paragraph selections, and inline node deletions. * fix(core): guard deleteSelection mutation behind dispatch check In editor.can() / can().chain() calls, dispatch is undefined and commands must not mutate the transaction. Changed the command to accept dispatch from props and only call tr.deleteRange().scrollIntoView() when dispatch is truthy, following the same pattern used by deleteRange and clearNodes.
Adds SCOPES.md listing valid commit scopes (monorepo packages + additional areas) and links to it from AGENTS.md so agents and contributors can pick the right scope when committing.
List all extension-* packages individually and fix stray characters in AGENTS.md from the earlier conflict resolution.
…ndle (#7851) * refactor(placeholder): improve performance when showOnlyCurrent is true * Make placeholder viewport-aware and improve performance on rendering * Refactor placeholder utilities and handle RTL Introduce useResolvedPath flag in placeholder to clarify logic Destructure classes in createPlaceholderDecoration to extract emptyNode and emptyEditor Add isScrollable helper and simplify findScrollParent detection Pick x coordinate based on editor direction in getViewportBoundaryPositions to support RTL layouts * Add changeset to optimize decoration traversal * Add dragImageProperties option to DragHandle * fix(placeholder): map placeholder position across transactions * fix(placeholder): add typesafety for throttle arguments * chore(placeholder): fix typo * chore(placeholder): fix typo * test(drag-handle): add tests for dragging with and without CSS filters * refactor(placeholder): don't map positions if the document hasn't changed * test(drag-handle): update tests * refactor(drag-handle): filter out empty properties * test(placeholder): add new tests for placeholder rendering * refactor(placeholder): use window as container for container boundaries * test(placeholder): fix throttle timer tests and adjust types
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )