[pull] main from ueberdosis:main#95
Merged
Merged
Conversation
* fix(core): return correct node from for non-text atom nodes * fix(core): return correct node from $pos() for non-text atom nodes * fix(core): return correct node from $pos() for non-text block atom nodes
…tracking (#7828) * fix(nodeview): optimize NodeView re-renders by implementing shallow prop comparison * fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking NodeViews no longer re-render when decorations or position change without content changes. Added trackNodeViewPosition option for reactive position prop. Removed internal nodeViewPositionRegistry. Added shallow prop comparison in ReactRenderer.updateProps(). * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * refactor: remove position prop, use getPos() as re-render trigger Instead of a separate reactive position prop, the trackNodeViewPosition option now triggers a re-render via getPos reference change. Users always use getPos() for position access. * fix: address Copilot review comments - Fix JSDoc for trackNodeViewPosition (no reactive position prop) - Call updateElementAttributes() in handlePositionUpdate - Only compute newPos in the nodeChanged branch * fix(vue): restore decoration class updates when node reference unchanged * fix(vue): sync currentPos in node-changed branch to prevent double re-render --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* test(core): add test for inserting plain text content * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…arately (#7844) * fix(markdown): serialize adjacent marks with different attributes separately * fix(markdown): address Copilot review feedback - Fix attrsEqual to check key presence in both objects and use Object.is - Remove duplicate JSDoc block in markSetsEqual - Make getMarksToOpenForSerialization attr-aware for continuing/ending logic - Hoist normalizeMarks to module level to avoid duplication
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )