Skip to content

[pull] dev from mrdoob:dev #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Mar 6, 2026
Merged

[pull] dev from mrdoob:dev #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1fe47
SSGINode: Remove dead code
mrdoob Mar 2, 2026
9657ec4
TSL: Improve `dispose()` of some FX addons. (#33126)
Mugen87 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/jsm/tsl/display/AfterImageNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ class AfterImageNode extends TempNode {
*/
this._textureNodeOld = texture( this._oldRT.texture );

/**
* The material for the composite pass.
*
* @private
* @type {?NodeMaterial}
*/
this._materialComposed = null;

/**
* The `updateBeforeType` is set to `NodeUpdateType.FRAME` since the node renders
* its effect once per frame in `updateBefore()`.
Expand Down Expand Up @@ -226,6 +234,8 @@ class AfterImageNode extends TempNode {
this._compRT.dispose();
this._oldRT.dispose();

if ( this._materialComposed !== null ) this._materialComposed.dispose();

}

}
Expand Down
11 changes: 11 additions & 0 deletions examples/jsm/tsl/display/AnamorphicNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ class AnamorphicNode extends TempNode {
*/
this._textureNode = passTexture( this, this._renderTarget.texture );

/**
* The material for the anamorphic pass.
*
* @private
* @type {?NodeMaterial}
*/
this._material = null;


/**
* The `updateBeforeType` is set to `NodeUpdateType.FRAME` since the node renders
* its effect once per frame in `updateBefore()`.
Expand Down Expand Up @@ -239,6 +248,8 @@ class AnamorphicNode extends TempNode {

this._renderTarget.dispose();

if ( this._material !== null ) this._material.dispose();

}

/**
Expand Down
10 changes: 10 additions & 0 deletions examples/jsm/tsl/display/BilateralBlurNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ class BilateralBlurNode extends TempNode {
this._textureNode = passTexture( this, this._verticalRT.texture );
this._textureNode.uvNode = textureNode.uvNode;

/**
* The material for the blur pass.
*
* @private
* @type {?NodeMaterial}
*/
this._material = null;

/**
* The `updateBeforeType` is set to `NodeUpdateType.FRAME` since the node renders
* its effect once per frame in `updateBefore()`.
Expand Down Expand Up @@ -318,6 +326,8 @@ class BilateralBlurNode extends TempNode {
this._horizontalRT.dispose();
this._verticalRT.dispose();

if ( this._material !== null ) this._material.dispose();

}

/**
Expand Down
10 changes: 10 additions & 0 deletions examples/jsm/tsl/display/GaussianBlurNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ class GaussianBlurNode extends TempNode {
this._textureNode = passTexture( this, this._verticalRT.texture );
this._textureNode.uvNode = textureNode.uvNode;

/**
* The material for the blur pass.
*
* @private
* @type {?NodeMaterial}
*/
this._material = null;

/**
* The `updateBeforeType` is set to `NodeUpdateType.FRAME` since the node renders
* its effect once per frame in `updateBefore()`.
Expand Down Expand Up @@ -303,6 +311,8 @@ class GaussianBlurNode extends TempNode {
this._horizontalRT.dispose();
this._verticalRT.dispose();

if ( this._material !== null ) this._material.dispose();

}

/**
Expand Down
4 changes: 0 additions & 4 deletions examples/jsm/tsl/display/SSGINode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,6 @@ class SSGINode extends TempNode {

const color = vec3( 0 );

const lastSampleViewPosition = vec3( viewPosition ).toVar();

Loop( { start: uint( 0 ), end: STEP_COUNT, type: 'uint', condition: '<' }, ( { i } ) => {

const offset = pow( abs( mul( stepRadius, float( i ).add( initialRayStep ) ).div( radiusVS ) ), EXP_FACTOR ).mul( radiusVS ).toConst();
Expand Down Expand Up @@ -529,8 +527,6 @@ class SSGINode extends TempNode {

} );

lastSampleViewPosition.assign( sampleViewPosition );

} );

return vec3( color );
Expand Down
Loading