Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/loaders/MaterialLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class MaterialLoader extends Loader {

if ( typeof json.vertexColors === 'number' ) {

material.vertexColors = ( json.vertexColors > 0 ) ? true : false;
material.vertexColors = json.vertexColors > 0;

} else {

Expand Down
2 changes: 1 addition & 1 deletion src/math/Triangle.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class Triangle {
_v1.subVectors( a, b );

// strictly front facing
return ( _v0.cross( _v1 ).dot( direction ) < 0 ) ? true : false;
return _v0.cross( _v1 ).dot( direction ) < 0;

}

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/Animation.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Animation {
* Constructs a new animation loop management component.
*
* @param {Renderer} renderer - A reference to the main renderer.
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
* @param {Info} info - Renderer component for managing metrics and monitoring data.
*/
constructor( renderer, nodes, info ) {
Expand All @@ -25,7 +25,7 @@ class Animation {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
*/
this.nodes = nodes;

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/Background.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Background extends DataMap {
* Constructs a new background management component.
*
* @param {Renderer} renderer - The renderer.
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
*/
constructor( renderer, nodes ) {

Expand All @@ -38,7 +38,7 @@ class Background extends DataMap {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
*/
this.nodes = nodes;

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/Bindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Bindings extends DataMap {
* Constructs a new bindings management component.
*
* @param {Backend} backend - The renderer's backend.
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
* @param {Textures} textures - Renderer component for managing textures.
* @param {Attributes} attributes - Renderer component for managing attributes.
* @param {Pipelines} pipelines - Renderer component for managing pipelines.
Expand Down Expand Up @@ -54,7 +54,7 @@ class Bindings extends DataMap {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
*/
this.nodes = nodes;

Expand Down
2 changes: 1 addition & 1 deletion src/renderers/common/CubeRenderTarget.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class CubeRenderTarget extends RenderTarget {
renderer.setMRT( currentMRT );

texture.minFilter = currentMinFilter;
texture.currentGenerateMipmaps = currentGenerateMipmaps;
texture.generateMipmaps = currentGenerateMipmaps;

mesh.geometry.dispose();
mesh.material.dispose();
Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/Pipelines.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Pipelines extends DataMap {
* Constructs a new pipeline management component.
*
* @param {Backend} backend - The renderer's backend.
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
*/
constructor( backend, nodes ) {

Expand All @@ -31,7 +31,7 @@ class Pipelines extends DataMap {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
*/
this.nodes = nodes;

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/RenderObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class RenderObject {
/**
* Constructs a new render object.
*
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
* @param {Geometries} geometries - Renderer component for managing geometries.
* @param {Renderer} renderer - The renderer.
* @param {Object3D} object - The 3D object.
Expand All @@ -77,7 +77,7 @@ class RenderObject {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
* @private
*/
this._nodes = nodes;
Expand Down
6 changes: 3 additions & 3 deletions src/renderers/common/RenderObjects.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class RenderObjects {
* Constructs a new render object management component.
*
* @param {Renderer} renderer - The renderer.
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
* @param {Geometries} geometries - Renderer component for managing geometries.
* @param {Pipelines} pipelines - Renderer component for managing pipelines.
* @param {Bindings} bindings - Renderer component for managing bindings.
Expand All @@ -32,7 +32,7 @@ class RenderObjects {
/**
* Renderer component for managing nodes related logic.
*
* @type {Nodes}
* @type {NodeManager}
*/
this.nodes = nodes;

Expand Down Expand Up @@ -179,7 +179,7 @@ class RenderObjects {
/**
* Factory method for creating render objects with the given list of parameters.
*
* @param {Nodes} nodes - Renderer component for managing nodes related logic.
* @param {NodeManager} nodes - Renderer component for managing nodes related logic.
* @param {Geometries} geometries - Renderer component for managing geometries.
* @param {Renderer} renderer - The renderer.
* @param {Object3D} object - The 3D object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class WebGLTimestampQueryPool extends TimestampQueryPool {
// Check if we have enough space for a new query pair
if ( this.currentQueryIndex + 2 > this.maxQueries ) {

warnOnce( `WebGPUTimestampQueryPool [${ this.type }]: Maximum number of queries exceeded, when using trackTimestamp it is necessary to resolves the queries via renderer.resolveTimestampsAsync( THREE.TimestampQuery.${ this.type.toUpperCase() } ).` );
warnOnce( `WebGLTimestampQueryPool [${ this.type }]: Maximum number of queries exceeded, when using trackTimestamp it is necessary to resolves the queries via renderer.resolveTimestampsAsync( THREE.TimestampQuery.${ this.type.toUpperCase() } ).` );
return null;

}
Expand Down
18 changes: 16 additions & 2 deletions src/renderers/webgpu/utils/WebGPUTextureUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,23 @@ class WebGPUTextureUtils {

} else if ( texture.isArrayTexture || texture.isDataArrayTexture || texture.isData3DTexture ) {

for ( let i = 0; i < options.image.depth; i ++ ) {
if ( texture.layerUpdates.size > 0 ) {

this._copyBufferToTexture( options.image, textureData.texture, textureDescriptorGPU, i, texture.flipY, i );
for ( const layerIndex of texture.layerUpdates ) {

this._copyBufferToTexture( options.image, textureData.texture, textureDescriptorGPU, layerIndex, texture.flipY, layerIndex );

}

texture.clearLayerUpdates();

} else {

for ( let i = 0; i < options.image.depth; i ++ ) {

this._copyBufferToTexture( options.image, textureData.texture, textureDescriptorGPU, i, texture.flipY, i );

}

}

Expand Down