Conversation
… is released outside of the component (#8899) * feat(rangeCalendar): allow to customise the behavior when the pointer is released outside of the component * feat: add test about pointerUpOutsideAction * Add assertions to tests * fix test * add more tests * change name of prop --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
* Select - add `shouldCloseOnSelect` This enables support for workflows where the select should stay open even after the user has selected an option. Fixes #8729 * fix test * simplify logic and add assertion that fails for the opposite case * forgot to save --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
) * feat(FieldError): expose elementType prop to control host element Fixes #9757 — Option C: expose elementType on FieldErrorProps so users can set elementType="div" when wrapping block-level children (e.g. <ul>) without triggering the DOMElement render mismatch warning. * test(FieldError): replace html-validation test with warn suppression tests
…8475) * fix: Picker select after close * apply pointerevents none to every child when popover is closing * fix the fix due to when state vs renders happen
…9677) Co-authored-by: Robert Snow <rsnow@adobe.com>
…26 (#9715) * fix: hover is applied after closing a modal with touch in safari iOS 26 * fix tests
ComboBoxProps was using `Validation<ComboBoxValidationValue>` without passing the `M` generic, so the validate callback's `value` field was always typed as `Key` (single mode) even with `selectionMode="multiple"`. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Since ComboBox supports allowsCustomValue, the validate function can be called with an empty selection in single mode. Update ValidationType to include null for single selection to match the runtime behavior. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…tationObserver (#9763) * fix: use attribute presence check for data-react-aria-top-layer in MutationObserver Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add test * remove unnecessary comment --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )