Conversation
* feat: s2 ListView * Explore highlight selection * fix docs type check * Add highlight selection option b to table * Add highlight selection option b to ListView * change selection behaviour of table for highlight mode * add option D as highlightMode * change font weight to bold for highlight selection * update background color * Start new highlight selection prototypes, ListView and part of TreeView * fix lint * update styles for listview and treeview * tableview * design updates * fix colors and add disabled items * fix lint * initialize docs * fix edgeToText import * update ListView (loadingMore, actionmenu, empty state, checkbox) * match selection styles to treeview/tableview * docs improvements * add jsdoc * support hasChildItems chevron * add stories * add hasChildItems example to docs * fix overflow in empty state * use objectFit: 'cover' for images * vertically align icons * add overflowMode * audit props * codemods * add chromatic stories * lint * add ListView testing docs * fix types * docs types * add description for search menu * docs types * fix selection checkbox visibility (always hide if disabled) * remove highlightMode prop * remove Tree/Table selection changes * remove unrelated Picker change * remove press scaling * keep bottom border width static to avoid 1px shift when highlight selection occurs. * add remaining states to chromatic * remove ListViewLoadMoreItem * fix prop types * update migration guide * remove bottom border radius for last item * prop types * remove style props from list item * remove seam mask element in favor of extending row background * make docs example wide * update docs content * add ActionBar support * fix gap for checkbox selection * docs update * style updates * remove renderer context * merge selection for checkbox selection * update docs * add LinkOut icon for links that open in new tab * fix storybook stories * add example to ActionBar docs * reserve space for trailing icon if at least one row has one * add padding to loading spinner * separate the icon and thumbnail slots examples in docs * docs types * move check image into chromatic folder * export ListViewContext from index.ts * cleanup story * use icons in all items in navigation docs * remove unused shorthands from macro theme * refactor to move isPrevSelected, isNextSelected, etc. logic out of GridList. * fix last item bottom border styles * pass id instead of item through render props (matches Table) * fix border styles * add explicit bottom border width --------- Co-authored-by: Reid Barber <reid@reidbarber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )