Conversation
…st item in submenu (#9691) * fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu * typo
* add unavailable menu item to RAC and S2 * add translations * add tests and stories * dont propagate submenutrigger props if non unavailable * fix test * add docs for unavailable menu item * fix docs lint * fix styling and copy * add endSlotProps so we can associate arbitrary elements with the menu item description * shift icon down 1px * adding alpha badge to RAC unavailable menu * adding code mod * fix lint and update todo copy * period * change to use aria-describedby via props * pull out ContextualHelpPopover and reuse submenuTrigger * update S2 menu tests, code mod, docs * fix styling and slot of contextual help * update examples, not sure why docs wont run * fix docs and automatically move focus into the Popover if not pointer modality this was for accessibility, ideally users should be moved into submenu/submenu dialogs unless it is hover * forgot one todo * review comments * add menu strings to intl script * remove RAC example
…alue (#9710) * chore: Warn if user has interactive elements in their custom Picker value * run check if selected value changes
* refactor: Centralize expandedKeys logic in TreeCollection * fix level logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )