Conversation
… setLocalTimeZone (#9678) * fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone When setLocalTimeZone is called with a timezone different from the browser's, the fast paths in getTimeZoneOffset and toAbsolute incorrectly use native Date (which always reflects the browser timezone) instead of the Intl-based path. This causes incorrect offset calculations for the overridden timezone. Skip the native Date fast paths when setLocalTimeZone has been called, falling back to the correct Intl.DateTimeFormat-based computation. Fixes #9669 * fix: use before/after comparison in resetLocalTimeZone test to avoid -0 vs 0 issue in UTC CI * fix: fix lint import ordering and add isLocalTimeZoneOverridden queries tests - Fix alphabetical import sorting in conversion.ts - Export isLocalTimeZoneOverridden from public index - Add isLocalTimeZoneOverridden unit tests in queries.test.js as requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )