Conversation
* initial tree stuff * fix virtualized tree section expanding, update methods to remove flattenTree * cleanup * more cleanup * update key after if its content node * fix types when checking content node * fix spacing * update dynamic story * update setSize with added getDirectChildren function * fix types, update at method * remove console logs * add collection dependency to gridlist * fix lint * update yarn lock * rename dynamic row section array * add tests, fix setSize for top level nodes inside a section * fix lint * remove comments * more cleanup * comments and stuff * fix tests * these changes were made in oct and it's now jan so... * lots of comments regarding skipping content nodes in tree * skip content nodes is listlayout and collections, update keyboard delegate * update yarn lock * update direct children function * comments * update direct children functiona and remove collectionode type from gridlist * update comments * updates * simplify logic for visible/non disabled item * comments, small fixes * make guarding against content node more robust * optimize filtering content nodes in list layout * optimize getting child array * add helper function for cloning * add comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )