Conversation
…us new Date() calls (#28724) The Issue: The GeneratorRegistry.snapshot() method creates a snapshot of all generators, including **NowGenerator** ``` class NowGenerator implements ValueGenerator { #now: Date = new Date() generate(): string { return this.#now.toISOString() } } ``` The **NowGenerator** was initializing new Date() in its property declaration, meaning it was called synchronously during every query preparation, even if now() was not used. The Fix: I modified **NowGenerator** to be lazy. ``` class NowGenerator implements ValueGenerator { #now: Date | undefined generate(): string { if (this.#now === undefined) { this.#now = new Date() } return this.#now.toISOString() } } ``` The #now field is now initialized as undefined, and new Date() is only called inside the **generate()** ``` class NanoIdGenerator implements ValueGenerator { generate(arg: unknown): string { if (typeof arg === 'number') { return nanoid(arg) } else if (arg === undefined) { return nanoid() } else { throw new Error('Invalid Nanoid generator arguments') } } } ``` method if it hasn't been initialized yet. Fixes #28588 Co-authored-by: jacek-prisma <malec@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )