Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/vr-tests-web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"html-react-parser": "4.0.0",
"@fluentui/tokens": ">=1.0.0-alpha",
"@fluentui/web-components": ">=3.0.0-alpha",
"@microsoft/fast-element": "2.0.0",
"@microsoft/fast-element": "^2.0.0",
"tslib": "^2.1.0"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: update fast-element dependency version",
"packageName": "@fluentui/chart-web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix(headless): fix Popover flipping behavior",
"packageName": "@fluentui/react-headless-components-preview",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: remove hoisted peer dependency entries",
"packageName": "@fluentui/web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: enhance accessibility attributes for drawer component",
"packageName": "@fluentui/web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix keyboard navigation regressions for tree and menu-list",
"packageName": "@fluentui/web-components",
"email": "machi@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: add tests for compound-button, dialog-body, drawer-body, menu-button, and menu-item components",
"packageName": "@fluentui/web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: synchronize compound-button template with button template",
"packageName": "@fluentui/web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: enhance accessibility attributes for dialog component",
"packageName": "@fluentui/web-components",
"email": "863023+radium-v@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"@microsoft/api-extractor": "7.51.0",
"@microsoft/api-extractor-model": "7.31.2",
"@microsoft/eslint-plugin-sdl": "1.0.1",
"@microsoft/fast-element": "2.10.4",
"@microsoft/focusgroup-polyfill": "^1.4.1",
"@microsoft/load-themed-styles": "1.10.26",
"@microsoft/loader-load-themed-styles": "2.0.17",
Expand All @@ -86,7 +87,7 @@
"@octokit/rest": "18.12.0",
"@oddbird/css-anchor-positioning": "0.4.0",
"@phenomnomnominal/tsquery": "6.1.3",
"@playwright/test": "1.55.1",
"@playwright/test": "1.56.1",
"@react-native/babel-preset": "0.73.21",
"@rnx-kit/eslint-plugin": "0.8.6",
"@rollup/plugin-node-resolve": "13.3.0",
Expand Down Expand Up @@ -256,7 +257,7 @@
"parse-diff": "0.7.1",
"patch-package": "8.0.0",
"path-browserify": "1.0.1",
"playwright": "1.55.1",
"playwright": "1.56.1",
"plop": "2.6.0",
"portfinder": "1.0.28",
"postcss": "8.5.10",
Expand Down Expand Up @@ -354,7 +355,7 @@
"prettier": "2.8.8",
"puppeteer": "24.42.0",
"ws": "8.17.1",
"playwright": "1.55.1",
"playwright": "1.56.1",
"**/prismjs": "^1.30.0",
"**/@tensile-perf/runner/express": "^4.22.1",
"**/tar-fs": "^2.1.4",
Expand Down
3 changes: 1 addition & 2 deletions packages/charts/chart-web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"test:dev": "node ./scripts/e2e.js"
},
"devDependencies": {
"@microsoft/fast-element": "2.0.0",
"@tensile-perf/web-components": "~0.2.2",
"@storybook/html": "9.1.17",
"@storybook/html-vite": "9.1.17",
Expand All @@ -79,7 +78,7 @@
"tslib": "^2.1.0"
},
"peerDependencies": {
"@microsoft/fast-element": "^2.0.0-beta.26 || ^2.0.0"
"@microsoft/fast-element": "^2.0.0"
},
"beachball": {
"disallowedChangeTypes": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,18 @@ describe('usePositioning', () => {
result.current.containerRef(node);
});

expect(node).toHaveStyle({ position: 'absolute', inset: 'auto', margin: '0px' });
expect(node).toHaveStyle({ position: 'fixed', inset: 'auto', margin: '0px' });
});

it('containerRef honors strategy: "fixed"', () => {
const result = mountHook({ strategy: 'fixed' });
it('containerRef honors strategy: "absolute"', () => {
const result = mountHook({ strategy: 'absolute' });
const node = document.createElement('div');

act(() => {
result.current.containerRef(node);
});

expect(node).toHaveStyle({ position: 'fixed' });
expect(node).toHaveStyle({ position: 'absolute' });
});

it('containerRef writes data-placement matching (position, align)', () => {
Expand All @@ -79,7 +79,7 @@ describe('usePositioning', () => {
expect(node).toHaveAttribute('data-placement', 'below-start');
});

it('containerRef sets position-try-fallbacks to the three-try flip chain by default', () => {
it('containerRef sets position-try-fallbacks to the default flip chain', () => {
const result = mountHook();
const node = document.createElement('div');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { usePlacementObserver } from './usePlacementObserver';
export type TargetElement = HTMLElement | PositioningVirtualElement;

const DEFAULT_FLIP = ['flip-block', 'flip-inline', 'flip-block flip-inline'];

const EMPTY_FALLBACK_POSITIONS: PositioningShorthandValue[] = [];

export function usePositioning(options: PositioningProps): PositioningReturn {
Expand All @@ -28,7 +29,7 @@ export function usePositioning(options: PositioningProps): PositioningReturn {
fallbackPositions = EMPTY_FALLBACK_POSITIONS,
offset,
coverTarget = false,
strategy = 'absolute',
strategy = 'fixed',
matchTargetSize,
positioningRef,
} = options;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import styles from './positioning.module.css';

export const MatchTargetSize = (): React.ReactNode => (
<div className={styles.column}>
<Popover open positioning={{ matchTargetSize: 'width' }}>
<Popover defaultOpen positioning={{ matchTargetSize: 'width' }}>
<PopoverTrigger>
<button className={`${styles.trigger} ${styles.triggerWide}`}>Click me</button>
</PopoverTrigger>
Expand Down
42 changes: 25 additions & 17 deletions packages/web-components/docs/web-components.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2514,18 +2514,24 @@ export class Dialog extends FASTElement {
ariaLabel: string | null;
ariaLabelledby?: string;
clickHandler(event: Event): boolean;
dialog: HTMLDialogElement;
// (undocumented)
protected dialogChanged(): void;
emitBeforeToggle: () => void;
connectedCallback(): void;
dialog: HTMLDialogElement;
// @internal
get dialogDescribedby(): string | undefined;
// @internal
get dialogLabel(): string | null | undefined;
// @internal
get dialogLabelledby(): string | undefined;
// @internal
get dialogModal(): boolean | undefined;
// @internal
get dialogRole(): string | undefined;
emitBeforeToggle(): void;
emitToggle: () => void;
hide(): void;
show(): void;
type: DialogType;
// (undocumented)
protected typeChanged(prev: DialogType | undefined, next: DialogType): void;
// @internal
protected updateDialogAttributes(): void;
}

// @public
Expand Down Expand Up @@ -2644,27 +2650,29 @@ export class Drawer extends FASTElement {
cancelHandler(): void;
// (undocumented)
clickHandler(event: Event): boolean;
// @internal (undocumented)
// (undocumented)
connectedCallback(): void;
dialog: HTMLDialogElement;
// @internal (undocumented)
disconnectedCallback(): void;
// @internal
get dialogDescribedby(): string | undefined;
// @internal
get dialogLabel(): string | null | undefined;
// @internal
get dialogLabelledby(): string | undefined;
// @internal
get dialogModal(): boolean | undefined;
// @internal
get dialogRole(): string | null;
emitBeforeToggle: () => void;
emitToggle: () => void;
hide(): void;
// (undocumented)
protected observeRoleAttr(): void;
position: DrawerPosition;
// (undocumented)
protected roleAttrObserver: MutationObserver;
role: string | null;
show(): void;
// (undocumented)
size: DrawerSize;
type: DrawerType;
// (undocumented)
protected typeChanged(): void;
// (undocumented)
protected updateDialogRole(): void;
}

// Warning: (ae-missing-release-tag) "DrawerBody" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal)
Expand Down
2 changes: 0 additions & 2 deletions packages/web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@
},
"devDependencies": {
"@custom-elements-manifest/analyzer": "0.10.10",
"@microsoft/fast-element": "2.0.0",
"@microsoft/focusgroup-polyfill": "^1.4.1",
"@tensile-perf/web-components": "~0.2.2",
"@storybook/html": "9.1.17",
"@storybook/html-vite": "9.1.17",
Expand Down
Loading
Loading