Conversation
# Why Code blocks rendered inside API reference tables show their syntax-highlighted tokens at 14px while top-level code blocks on the same page render at 12px, producing visible size inconsistency. The mismatch is easiest to see on pages that mix top-level Examples (for example, `NativeTabs.Trigger.VectorIcon`) with in-table Examples (`SrcIcon`, `XcassetIcon`) on the same `expo-router/unstable-native-tabs` reference page. <img width="2708" height="1706" alt="CleanShot 2026-05-04 at 22 33 59@2x" src="https://github.com/user-attachments/assets/71eee302-c649-4713-882a-ab659561aad9" /> <img width="2708" height="1268" alt="CleanShot 2026-05-04 at 22 33 57@2x" src="https://github.com/user-attachments/assets/05cf70ce-87dc-492c-b98c-69a2c4350b51" /> # How The `Table` component in `ui/components/Table/Table.tsx` has `[&_span]:text-sm` to size prose spans inside cells, which also matches Prism's token spans inside `<code>` and inflates them to 14px. A companion rule `[&_code_span]:text-inherit` was meant to undo this, but Tailwind's `text-inherit` only resets `color`, not `font-size`. Replace it with `[&_code_span]:text-xs` so token spans render at the same 12px used by top-level code blocks. # Test Plan Open `/versions/latest/sdk/router/native-tabs/` and compare the Example block under `NativeTabs.Trigger.VectorIcon` with the Example blocks inside the `SrcIcon` and `XcassetIcon` interface tables: http://localhost:3002/versions/latest/sdk/router/native-tabs/#srcicon **Preview** <img width="2398" height="1652" alt="CleanShot 2026-05-10 at 15 21 31@2x" src="https://github.com/user-attachments/assets/d288b0f3-0eba-4993-8d76-bab5457fad0d" /> <img width="2288" height="1622" alt="CleanShot 2026-05-10 at 15 21 34@2x" src="https://github.com/user-attachments/assets/79dc3005-8786-47c5-a278-9c58e32d3411" /> <img width="2324" height="1148" alt="CleanShot 2026-05-10 at 15 21 38@2x" src="https://github.com/user-attachments/assets/2f8be485-8a07-4d9d-8aac-1a152c80dbe0" /> # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/nicknisi/dotfiles/wiki/Pull-Request-Guidelines). - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md).
…Move` (#45327) # Why https://expo.canny.io/feature-requests/p/expo-maps-add-latitudedelta-and-longitudedelta-to-googlemapsview-oncameramove - iOS returns `latitudeDelta` and `longitudeDelta` in `onCameraMove` event. This PR adds same for android's `onCameraMove` event. - iOS fires `onCameraMove` on initial mount while android does not. This PR also fixes that. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Uses [VisibleRegion](https://developers.google.com/maps/documentation/android-sdk/reference/com/google/android/libraries/maps/model/VisibleRegion)'s `latLngBounds` in `cameraState` to calculate the deltas - Added `CameraMoveEvent` shared type for both platform's `onCameraMove` event - Pass `wasLoaded` in the `LaunchedEffect` deps to trigger the `onCameraMove` when map is ready on initial mount. <!-- How did you build this feature or fix this bug and why? --> # Test Plan Added example in android and iOS maps. https://github.com/user-attachments/assets/3b54f0a1-5335-45ff-879e-ee2d093cfae1 <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Docs needs to be updated, after android toolbar was added. I also added a follow-up ticket for adding screenshots - https://linear.app/expo/issue/ENG-21061/add-screenshots-to-toolbar-docs # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )