Conversation
# Why Fix misleading error messages when using `File.create` for Android SAF URIs Mentioned [here](#41717 (comment)) # How Moved the URI check to the top so it fails first with meaningful error # Test Plan Tried `File.create` for SAF URI
This reverts commit c39feae.
# Why A follow-up to #45244. At the moment when no color is passed to the `Icon` it uses `Color.Unspecified`. This is not aligned with jetpack-compose where the default is `LocalContentColor` (see #45244 (comment) for more details) # How 1. Add native `inheritTint` prop, which decides wether to use `LocalContentColor` (true) or `Color.Unspecified` (false) 2. In JS API, when tintColor is: - defined - use the color - `undefined` - set `inheritTint` to `true` - `null` - set `inheritTint` to `false` # Test Plan Bare-expo ```tsx <HorizontalFloatingToolbar colors={{ toolbarContainerColor: '#1B5E20', toolbarContentColor: '#AAA', fabContainerColor: '#FFB300', fabContentColor: '#0000FF', }} ``` <img width="411" height="196" alt="Screenshot 2026-05-06 at 10 33 38" src="https://github.com/user-attachments/assets/b6fd0ceb-3f53-4067-a160-7201d5f31515" /> ```tsx // Light <DropdownMenuItem elementColors={{ leadingIconColor: '#ff0000', textColor: '#00ff00', trailingIconColor: '#0000ff', }} .... // Disabled <DropdownMenuItem enabled={false} elementColors={{ leadingIconColor: '#ff0000', textColor: '#00ff00', trailingIconColor: '#0000ff', disabledLeadingIconColor: '#808080', disabledTextColor: '#808080', disabledTrailingIconColor: '#808080', }} ``` <img width="273" height="332" alt="Screenshot 2026-05-06 at 10 32 40" src="https://github.com/user-attachments/assets/acdbfdfd-fb9b-44d0-b628-99a67b613c97" /> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
# Why docs were missing <!----> # How add docs <!----> # Test Plan read the docs, test the samples <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )