Skip to content

[pull] main from expo:main#833

Merged
pull[bot] merged 3 commits intocode:mainfrom
expo:main
May 5, 2026
Merged

[pull] main from expo:main#833
pull[bot] merged 3 commits intocode:mainfrom
expo:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 5, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

vonovak and others added 3 commits May 5, 2026 09:38
# Why

notifications do not require real devices

<!--
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
-->

# How

update docs to not require real device for push notifications

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…d in the same project (#45323)

# Why

As of SDK 56, having both router and react-navigation installed in the
same project, suggests an issue or need to perform the router migration.
Add the expo-doctor check for better visibility

# How

1. Detect if both are installed
2. Show error and migration guide link for next steps

# Test Plan

1. CI
2. Router project with `@react-navigation` installed directly as
dependency

<img width="727" height="184" alt="Screenshot 2026-05-04 at 10 00 53"
src="https://github.com/user-attachments/assets/0ab91384-1ddb-40c9-804f-e5fb40d5d241"
/>

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…#45367)

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
Fixes #45305.

The SwiftUI `DatePicker` documentation listed `locale`, `timeZone`, and
`disabled` as component props on `<DatePicker>`. However,
`DatePickerProps` (in
`packages/expo-ui/src/swift-ui/DatePicker/index.tsx`) doesn't expose any
of them. They are actually applied through these modifiers:
  - `disabled` -> `disabled()` (from `@expo/ui/swift-ui/modifiers`)
  - `locale` ->`environment('locale', ...)`
  - `timeZone` -> `environment('timeZone', ...)`

Additionally, the `## Custom locale` and `## Custom time zone` sections
were also duplicated in the page (each appeared twice).

# How
<!--
How did you build this feature or fix this bug and why?
-->

- Rewrote the "Disabled picker", "Custom locale", and "Custom time zone"
examples to apply the values via the `modifiers` prop, matching the real
usage in
`apps/native-component-list/src/screens/UI/DatePickerScreen.ios.tsx`.
- Removed the duplicated `## Custom locale` and `## Custom time zone`
sections.

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

- Ran the docs site locally with `pnpm dev` and verified the DatePicker
page renders the updated "Disabled picker", "Custom locale", and "Custom
time zone" sections without duplicates and that the code snippets are
syntactically valid.



# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
@pull pull Bot locked and limited conversation to collaborators May 5, 2026
@pull pull Bot added the ⤵️ pull label May 5, 2026
@pull pull Bot merged commit 36e13a5 into code:main May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants