[pull] latest from ag-grid:latest#721
Merged
pull[bot] merged 6 commits intocode:latestfrom May 8, 2026
Merged
Conversation
* Rename e2e.sh to docs-e2e.sh and update references Updates the helper script name to be more descriptive, and documents the new docs-e2e.sh commands in AGENTS.md, rulesync rules, and package.json. * fix spelling
* AG-17221 Fix React cell render loop on column drag Add an early-return in cellComp.tsx's useLayoutEffect on [renderDetails] when the inner compDetails reference is unchanged. Without this guard, a wrapper-only renderDetails update (new wrapper object holding the same compDetails ref) would call refresh() → setRenderKey → renderer remount → cellCtrl re-emits compDetails → repeat. With renderers whose refresh() returns false (e.g. agGroupCellRenderer), this produced an infinite "Maximum update depth exceeded" loop, observed during column drag-and-drop on auto group columns. Fix #AG-17221 * AG-17221 Combine renderDetails guards into a single check Fold the new compDetails-identity guard into the existing nullish check. Net behavioural change: rowDragCompRef.refreshVisibility() now skips on wrapper-only renderDetails updates, which is consistent with the rest of the effect — if compDetails hasn't changed there's nothing for row-drag visibility to react to. * Reduce duplication
* AG-3390 - Port overrideSocialImage prop to Layout.astro Cherry-picks the Layout.astro plumbing from PR #13628 (b35.2.1) so pages on latest can override the default social card via `overrideSocialImage`. * AG-3390 - Sync beyond-the-prompt campaign from b35.2.1 - Replaces beyond-the-prompt page and stylesheet with the redesigned versions from b35.2.1 (#13628, #13645). - Adds the new SVG portraits (incl. orange-bg variants), social card, Savoy venue images, replacement webp speakers, and bryntum-logo.webp. - Removes orphaned venue-1/2/3.webp and bryntum-logo.png that the old page referenced. - Wires up showAnnouncementBanner in Layout.astro so the page can suppress the announcement banner on itself. * AG-3390 - Drop unused announcementBannerProps interface field Matches b35.2.1's tidy-up from #13628; the field had no callers and the hardcoded internal const of the same name (used by the page-wide banner) is unaffected.
* AG-3390 - Add boilerplate files back in * git subrepo push external/ag-website-shared subrepo: subdir: "external/ag-website-shared" merged: "a75e88d9149" upstream: origin: "git@github.com:ag-grid/ag-website-shared.git" branch: "latest" commit: "a75e88d9149" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "30db3b8"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )