Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .rulesync/rules/ag-grid.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This file provides guidance to AI Agents when working with code in this reposito
### Quick Reference

- **Main branch:** `latest`
- **Format:** `yarn nx format` (run before commits)
- **Format:** `yarn nx format --sort-root-tsconfig-paths=false` (run before commits)
- **Type-check:** `yarn nx build:types <package>` (run before commits)
- **Lint:** `yarn nx lint <package>` (run before commits)
- **Build:** `yarn nx build <package>`
Expand All @@ -34,7 +34,7 @@ This file provides guidance to AI Agents when working with code in this reposito
- **Main constraint:** Community and enterprise runtime bundles stay dependency-free beyond AG Grid code.
- **Default branch:** Target `latest`; follow release/JIRA naming conventions below for topic branches.
- **Build monitoring:** Check `node_modules/.cache/ag-watch-status.json` to monitor watch state (`yarn nx dev`) and build health (see [Development Server Guide](.rulesync/rules/dev-server.md)).
- **Formatting:** Run `yarn nx format` from the repo root before proposing commits.
- **Formatting:** Run `yarn nx format --sort-root-tsconfig-paths=false` from the repo root before proposing commits.
- **Typechecking:** Run `yarn nx build:types <package>` from the repo root before proposing commits.
- **Linting:** Run `yarn nx lint <package>` from the repo root before proposing commits.
- **Baseline verification:** Expect to run `yarn nx test ag-grid-community`, `yarn nx test ag-grid-enterprise`, and `yarn nx e2e ag-grid-docs` after meaningful grid changes.
Expand Down Expand Up @@ -75,7 +75,7 @@ For detailed information about preferred technologies and architectural constrai
- `yarn install` – install dependencies after cloning or when the Yarn lockfile changes.
- `./external/ag-shared/scripts/install-for-cloud/install-for-cloud.sh` – install dependencies and tooling in a remote environment - use this in preference to `yarn install` to ensure all global tools are installed.
- `yarn nx clean` – purge all dist folders when switching branches or before packaging releases.
- `yarn nx format` – format repo files; run from the project root before committing.
- `yarn nx format --sort-root-tsconfig-paths=false` – format repo files; run from the project root before committing.
- `yarn nx build <package>` – compile a specific package after code edits.
- `yarn nx build:types <package>` – regenerate declaration files when touching exported APIs.
- `yarn nx build:package <package>` – create ESM/CJS bundles to validate publishable output.
Expand Down Expand Up @@ -154,7 +154,7 @@ For code quality guidelines, see [Code Quality Guide](.rulesync/rules/code-quali

Essential practices:

- Run `yarn nx format` before committing
- Run `yarn nx format --sort-root-tsconfig-paths=false` before committing
- Self-review your changes before proposing commits
- Ensure tests exercise real implementations, not test helpers

Expand Down
2 changes: 1 addition & 1 deletion .rulesync/skills/technology-stack/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The core grid logic is framework-agnostic. Framework-specific wrappers (`ag-grid
## Code Style

- **ESLint**: Linting with custom rules
- **Prettier**: Code formatting (via `yarn nx format`)
- **Prettier**: Code formatting (via `yarn nx format --sort-root-tsconfig-paths=false`)
- **TypeScript Strict Mode**: Enforced across all packages

## Browser Support
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -326,24 +326,7 @@ test.agExample(import.meta, () => {
],
]);
} else {
expect(eventLog).toEqual([
['isCancelBeforeStart', []],
[
'cellEditingStopped',
{
newValue: undefined,
oldValue: 'Alice',
value: 'Alice',
valueChanged: false,
},
],
[
'cellEditingStarted',
{
value: 'Alice',
},
],
]);
expect(eventLog).toEqual([['isCancelBeforeStart', []]]);
}
} else {
if (agFramework.startsWith('react')) {
Expand All @@ -356,14 +339,7 @@ test.agExample(import.meta, () => {
],
]);
} else {
expect(eventLog).toEqual([
['isCancelBeforeStart', []],
[
'cellEditingStopped',
{ newValue: undefined, oldValue: 'Alice', value: 'Alice', valueChanged: false },
],
['cellEditingStarted', { value: 'Alice' }],
]);
expect(eventLog).toEqual([['isCancelBeforeStart', []]]);
}

await expect(cell).toHaveText('Alice');
Expand Down
6 changes: 3 additions & 3 deletions external/ag-shared/prompts/skills/batch-lint-cleanup/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ grep -c "<rule-name>" /tmp/lint-fix.txt || echo "0"

```bash
# Format all changes
yarn nx format
yarn nx format --sort-root-tsconfig-paths=false

# Run full lint to ensure no new issues
yarn nx lint <affected-packages>
Expand Down Expand Up @@ -178,7 +178,7 @@ For non-auto-fixable rules or remaining violations after auto-fix:
5. **When complete:**

```bash
yarn nx format
yarn nx format --sort-root-tsconfig-paths=false
yarn nx lint <affected-packages>
yarn nx build:types <affected-packages>

Expand Down Expand Up @@ -206,7 +206,7 @@ For non-auto-fixable rules or remaining violations after auto-fix:

**Before ANY commit:**

1. ✅ `yarn nx format` passes
1. ✅ `yarn nx format --sort-root-tsconfig-paths=false` passes
2. ✅ `yarn nx lint <affected-packages>` passes
3. ✅ `yarn nx build:types <affected-packages>` passes
4. ✅ Only files related to the rule are changed
Expand Down
2 changes: 1 addition & 1 deletion external/ag-shared/prompts/skills/sync-ag-shared/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ Common companion tasks:
- Update `.rulesync/` symlinks if skills/rules were added, renamed, or removed.
- Update product-specific configurations if ag-shared scripts changed.
- Run verification: `./external/ag-shared/scripts/setup-prompts/verify-rulesync.sh`.
- **Run `npx nx format` (or equivalent formatter) before committing** to avoid CI formatting check failures.
- **Run `npx nx format --sort-root-tsconfig-paths=false` (or equivalent formatter) before committing** to avoid CI formatting check failures.

### Iterative Push/Pull (if needed)

Expand Down
Loading