Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/database-projects-issues-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Update Database Team Project Fields

env:
PROJECT_NUMBER: '3'
DOMAIN_LABELS: '["domain::database", "domain::core"]'
DOMAIN_LABELS: '["domain::database"]'
STATUS_FIELD_NAME: 'Status'
STATUS_TODO: 'Todo'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/database-projects-pr-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Database Team PR Automation

env:
PROJECT_NUMBER: '3'
DOMAIN_LABELS: '["domain::database", "domain::core"]'
DOMAIN_LABELS: '["domain::database"]'
STATUS_FIELD_NAME: 'Status'
REVIEW_STATUS_FIELD_NAME: 'Review Status'
STATUS_IN_PROGRESS: 'In Progress'
Expand Down
8 changes: 4 additions & 4 deletions backend/src/baserow/contrib/automation/nodes/node_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,12 @@ def prepare_values(
:return: The prepared values for the router node.
"""

if instance:
service = instance.service.specific

service_values = values.get("service", {})
if instance and "edges" in service_values:
prepared_uids = [
str(edge["uid"]) for edge in values["service"].get("edges", [])
str(edge["uid"]) for edge in service_values.get("edges", [])
]
service = instance.service.specific
persisted_uids = [str(edge.uid) for edge in service.edges.only("uid")]
removed_uids = list(set(persisted_uids) - set(prepared_uids))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,44 @@ def test_updating_router_node_with_edge_removals_when_they_have_output_nodes_dis
}


@pytest.mark.django_db
def test_updating_router_node_without_service_allowed(
api_client,
data_fixture,
):
user, token = data_fixture.create_user_and_token()
workflow = data_fixture.create_automation_workflow(user)
service = data_fixture.create_core_router_service(default_edge_label="Default")
router = data_fixture.create_core_router_action_node(
workflow=workflow, service=service, label="Original"
)
edge = data_fixture.create_core_router_service_edge(
service=service, label="Do this", condition="'true'"
)

assert (
workflow.get_graph().get_node_at_position(router, "south", str(edge.uid))
is not None
)

response = api_client.patch(
reverse(API_URL_ITEM, kwargs={"node_id": router.id}),
{"label": "Modified"},
**get_api_kwargs(token),
)
assert response.status_code == HTTP_200_OK
response_json = response.json()
assert response_json["label"] == "Modified"
assert response_json["service"]["edges"] == [
{
"uid": str(edge.uid),
"label": edge.label,
"order": AnyStr(),
"condition": edge.condition,
}
]


@pytest.mark.django_db
def test_deleting_router_node_with_output_nodes_disallowed(api_client, data_fixture):
user, token = data_fixture.create_user_and_token()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "bug",
"message": "Resolved an issue which prevented router nodes from being renamed once they had branches.",
"issue_origin": "github",
"issue_number": null,
"domain": "automation",
"bullet_points": [],
"created_at": "2026-02-19"
}
Loading