Conversation
* fix(playwright-service): harden against SSRF * fix cubic feedback * fix cubic again * fix test
…sing (#3139) * feat(native): add structured tracing, panic safety, and Sentry reporting for Rust native module - Add tracing infrastructure (logging.rs) with catch_unwind panic recovery and backtrace capture - Pass NativeContext (scrapeId, url) from TS to Rust for trace continuity - Emit Rust logs through Winston with source:"native" labels via emitNativeLogs helper - Wrap Rust calls in Sentry spans (native.pdf.detect, native.pdf.process, native.document.convert) - Add missing try-catch + captureExceptionWithZdrCheck to document converter - Fix unsafe unwrap() calls in html.rs that could crash workers silently * scope PR to PDF only: revert document/html changes * fix: preserve native logs on error/panic paths TracingResult now wraps the inner Result so logs are always returned. On NAPI errors, logs are serialized into the error message via embed_logs_in_error and extracted on the TS side via extractAndEmitNativeLogs before Sentry reporting. * fix: only strip embedded logs from error message after successful parse * fix(native): change strip to debuginfo to preserve unwind tables strip="symbols" removes .eh_frame unwind tables, causing catch_unwind to fail in release builds (SIGABRT instead of recoverable error). strip="debuginfo" keeps unwind tables while still removing debug info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )