fix(coding-agent): pin @earendil-works/pi-* deps to upstream versions#11
Open
davidbasilefilho wants to merge 2 commits into
Open
fix(coding-agent): pin @earendil-works/pi-* deps to upstream versions#11davidbasilefilho wants to merge 2 commits into
davidbasilefilho wants to merge 2 commits into
Conversation
The published @code-yeongyu/senpi package was declaring @earendil-works/pi-* dependencies at CalVer versions (e.g. ^2026.5.15-3) that don't exist on npm for those upstream packages -- they use semver (0.74.0). Fix: pin deps to ^0.74.0 and update sync-versions.js to skip overwriting @earendil-works/ prefixed packages during release.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Pins packages/coding-agent (published as @code-yeongyu/senpi) to upstream npm versions of @earendil-works/pi-* to prevent global installs from failing due to non-existent CalVer ranges, and updates the release sync script so future releases don’t overwrite those pins.
Changes:
- Updated
@earendil-works/pi-agent-core,@earendil-works/pi-ai, and@earendil-works/pi-tuidependency ranges inpackages/coding-agentto^0.74.0. - Added a guard in
scripts/sync-versions.jsto skip syncing@earendil-works/*deps for the published package@code-yeongyu/senpi. - Regenerated
package-lock.jsonto reflect the new dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/sync-versions.js | Prevents the release sync script from rewriting upstream-pinned @earendil-works/* deps in the published package. |
| packages/coding-agent/package.json | Pins @earendil-works/pi-* dependencies to upstream npm versions so installs don’t reference non-existent CalVer ranges. |
| package-lock.json | Updates the lockfile to match the new upstream dependency ranges and resulting transitive deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+51
| // Packages under this prefix are published by upstream and use their own versioning. | ||
| // Only the published @code-yeongyu/senpi should skip them -- other workspace packages | ||
| // (agent, web-ui) need internal deps to stay in sync during release. |
Comment on lines
+52
to
+53
| const SKIP_SYNC_PREFIX = "@earendil-works/"; | ||
| const PUBLISHED_PACKAGE = "@code-yeongyu/senpi"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
@earendil-works/pi-agent-core,@earendil-works/pi-ai, and@earendil-works/pi-tuiinpackages/coding-agentfrom the fork's CalVer (^2026.5.15-3) to upstream npm versions (^0.74.0). Without this,bun i -g @code-yeongyu/senpifails because the CalVer range doesn't exist on npm.Changes
packages/coding-agent/package.json: Changed dep ranges from^2026.5.15-3to^0.74.0scripts/sync-versions.js: Added skip guard so future releases don't overwrite these pinned deps for@code-yeongyu/senpi(the published package only -- other workspace packages still get their internal deps synced)package-lock.json: Regenerated to match new rangesVerification
npm install --ignore-scriptssucceeds@earendil-works/pi-*used by coding-agent exist in upstream0.74.0Summary by cubic
Fixes failed installs of
@code-yeongyu/senpiby aligning dependency versions with upstream npm releases instead of the fork’s CalVer range.@earendil-works/pi-agent-core,@earendil-works/pi-ai, and@earendil-works/pi-tuiinpackages/coding-agentto^0.74.0.scripts/sync-versions.jsto skip syncing@earendil-works/*only for the published@code-yeongyu/senpiand clarified comments/quoting style.package-lock.json.Written for commit 3386a32. Summary will update on new commits. Review in cubic