fix(test): make Node tests portable on Windows#107
Closed
daehyeonxyz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR! Changes to LazyCodex land through oh-my-openagent — could you open this against omo-codex over there instead? PRs in this repository can't be merged. If you're working with a coding agent, prompt it like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node --test test/*.test.mjspackage scripts with a small Node runner that enumerates top-level.test.mjsfiles without relying on shell glob expansionfileURLToPath()so Windows drive paths are handled correctlypackages/omo-codexwrapper packageVerification
npm testfrom the repository root: 9 pass, 0 failnode --test test\aggregate-build.test.mjsfromplugins/omo: 1 pass, 0 fail, 1 skippedgit diff --checkNote
npm testfromplugins/omonow reaches the full plugin suite on Windows instead of failing before discovery. That broader suite is still red on this checkout with unrelated fixture/artifact failures: 219 pass, 33 fail, 2 skipped. The visible failures include current aggregate MCP path expectations, auto-update marketplace-flow expectations, and missing@oh-my-opencode/shared-skillsimports.Summary by cubic
Make Node tests portable on Windows by replacing shell globbing with a Node-based runner and fixing Windows path handling in tests. This lets
npm testrun on Windows and keeps aggregate plugin tests robust in mirror layouts.scripts/run-node-test-files.mjsto enumerate.test.mjsfiles and invokenode --testwithout shell globs.testscripts in root andplugins/omoto use the new runner.fileURLToPathin thelazycodex-aibin test.packages/omo-codexis absent, add apathExistshelper, and assert the newtestscript value.Written for commit 1d30207. Summary will update on new commits.