fix: auto-bootstrap submodule before typecheck/test/build/check#4
Merged
Conversation
Without this, a fresh checkout running 'npm run typecheck' fails because the submodule's dist/cli.js does not exist yet. Adds 'pre*' lifecycle hooks that call the bootstrap script. The bootstrap script is now idempotent (skips when dist/cli.js already exists), so the chained pre-step is effectively free on subsequent invocations.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, a fresh checkout running
npm run typecheckfails because the submodule'sdist/cli.jsdoes not exist yet.Adds
pre*lifecycle hooks (pretypecheck, pretest, prebuild, precheck) that call the bootstrap script. The bootstrap script is now idempotent (skips whendist/cli.jsalready exists), so the chained pre-step is effectively free on subsequent invocations.Verified locally:
npm run typecheckauto-bootstraps submodule then succeedsnpm run typecheckis fast (no rebuild)npm testruns cleanly (7 tests pass)Summary by cubic
Automatically bootstraps the
lsp-tools-mcpsubmodule before typecheck, test, build, and check to fix fresh-clone failures and keep repeated runs fast.pretypecheck,pretest,prebuild, andprecheckhooks to run the bootstrap script.packages/lsp-tools-mcp/dist/cli.jsexists (use--forceto rebuild).npm run typecheck/test/build/checkwithout manual steps.Written for commit 8971c4a. Summary will update on new commits. Review in cubic