Skip to content

feat(plugin-typescript): add TS core logic #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BioPhoton merged 13 commits into from
Feb 14, 2025
Merged

feat(plugin-typescript): add TS core logic #932

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7552cbd
feat(plugin-typescript): add core logic
BioPhoton Feb 12, 2025
50cdeb4
test(plugin-typescript): fix integration tests
BioPhoton Feb 12, 2025
a84ce3d
fix(plugin-typescript): add missing deps
BioPhoton Feb 12, 2025
d3aae4d
Update packages/plugin-typescript/src/lib/runner/runner.ts
BioPhoton Feb 12, 2025
d8d7395
Update packages/plugin-typescript/src/lib/runner/runner.ts
BioPhoton Feb 12, 2025
ab4c4f7
fix(plugin-typescript): rename groups
BioPhoton Feb 14, 2025
9e6af64
fix(plugin-typescript): refined groups
BioPhoton Feb 14, 2025
322a453
fix(plugin-typescript): refined logic and types
BioPhoton Feb 14, 2025
88d492e
fix(plugin-typescript): refined tests
BioPhoton Feb 14, 2025
f3b5086
fix(plugin-typescript): adjust pkg dependencies
BioPhoton Feb 14, 2025
7aaddf2
fix(plugin-typescript): adjust pkg dependencies
BioPhoton Feb 14, 2025
488f724
fix(plugin-typescript): fix typing
BioPhoton Feb 14, 2025
68c35dc
fix(nx-plugin): adjust pkd deps
BioPhoton Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugin-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
},
"type": "module",
"dependencies": {
"@code-pushup/models": "0.58.0",
"@code-pushup/utils": "0.58.0"
"@code-pushup/models": "*",
"@code-pushup/utils": "*"
Comment thread
BioPhoton marked this conversation as resolved.
Outdated
},
"peerDependencies": {
"typescript": ">=4.0.0"
Expand Down
3 changes: 1 addition & 2 deletions packages/plugin-typescript/src/lib/runner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ export function createRunnerFunction(options: RunnerOptions): RunnerFunction {
Partial<Record<CodeRangeName, Pick<AuditOutput, 'slug' | 'details'>>>
>((acc, diag) => {
const slug = tsCodeToAuditSlug(diag.code);
const existingIssues: Issue[] =
(acc[slug] && acc[slug].details?.issues) || ([] as Issue[]);
const existingIssues: Issue[] = acc[slug]?.details?.issues ?? [];
return {
...acc,
[slug]: {
Expand Down