Fixes issues with redux.#315
Merged
Merged
Conversation
We need to make this package's redux the same version as the apps main. We also need to make sure we don't update state inside a reducer and instead queue a microtask. Otherwise the app crashes when selecting datasets.
sanchitmalhotra126
approved these changes
May 26, 2026
| // microtask so the dispatch fully unwinds before the callback fires. | ||
| if (state.instructionsKeyCallback) { | ||
| const callback = state.instructionsKeyCallback; | ||
| queueMicrotask(() => |
There was a problem hiding this comment.
Nice find! Ideally we wouldn't have a callback in here at all and/or move this to a thunk, but that can happen later
Contributor
Author
There was a problem hiding this comment.
Yep. I don't like a bit of how this is working from a certain standpoint, but the key word there is it is working. When we port it into the actual main repo, we have much more opportunity to clean it up. I'm not sure if ml-playground itself really needs its own redux to do what it is doing anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to make this package's redux the same version as the apps main.
We also need to make sure we don't update state inside a reducer and instead queue a microtask. Otherwise the app crashes when selecting datasets.
This problem was discovered on the last level of ailab in CSD Unit 7. It's a rare interaction. This will fix the last remaining issue that I can see at the moment such that we can enable this build on production.