[Design2-231] [Button] Use Mui Button instead of DSCO Button in several pages #70239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent to MUI Button
…> for better compatibility with MUI's variant system
…sx to check that mui version of button looks the same as dsco button
…various button states
…and centered spinner
…sting button stories)
…or and size extensions
…d force hover as complete
…atalogCard and ExpandedCurriculumCatalogCard
…ingsFilters and NoMatchingSearchResultsFound
… to MUI Button and IconButton with updated prop handling
…pe definitions in package.json
levadadenys
changed the title
🖼️ Storybook Visual Comparison ReportA difference was found in our Storybook front-end visual comparison testing against the Remediation steps:
|
levadadenys
changed the base branch from
staging
to
denys/design2/design2-331-useMuiButtonInCode
levadadenys
requested review from
drizco,
kelbyhawn,
kobryan0619,
lfryemason and
stephenliang
levadadenys
force-pushed
the
denys/design2/design2-331-useMuiButtonInCode
branch
from
d6e6e31 to
bde9f2f
Compare
levadadenys
changed the base branch from
denys/design2/design2-331-useMuiButtonInCode
to
staging
Contributor
Author
|
Closing this PR Because of git log mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Design2-231] [Button] Use Mui Button instead of DSCO Button in several pages
No major visual changes expected. Minor visual changes (e.g. font smoothing, iconOnlyButton few px difference) are possible.
Replaced DSCO Button with Mui Button with help of Codemod from #70212
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: