feat(dynamic-client): extract dynamic-address-resolution#996
Open
mikhd wants to merge 3 commits into
Open
Conversation
* feat: extract dynamic-address-resolution * feat: add dynamic-address-resolution to dynamic-client - Cleaned dynamic-client from dynamic-address-resolution files - Hook dynamic-address-resolution, fix imports * chore: re-build custom idls * fix: cleanup * feat: export DEFAULT_VALUE_ENCODER_SUPPORTED_NODE_KINDS from dynamic-address-resolution * fix: types import * fix: async describe * fix: cleanup
🦋 Changeset detectedLatest commit: 5d6add5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR [1] extracts Account address resolution functionality from
dynamic-clientintodynamic-address-resolutionpackage (including standalone PDA resolution). Packagedynamic-clientwas cleaned and now usesdynamic-address-resolution.Change
dynamic-address-resolutioncontains full functionality of Address resolution for the given Instruction's Account. ExportsresolveStandalonePda,resolveInstructionAccountAddressand address helpers.utilfiles andtestsdisplayed as new are not new.dynamic-client.Minor
isConvertibleAddress->isAddressConvertible,createInputValueTransformer->createCodecInputTransformer.Public API:
dynamic-address-resolution
dynamic-client
Unchanged
Notes
This is 1st out of 4 forthcoming dependent PRs. In the next we will do more in terms of spliting:
Extract dynamic-instructions - it will contain functionality for building Solana kit Instruction and AccountMeta. Uses dynamic-address-resolution.
Split type generations between dynamic-address-resolution, dynamic-instructions, dynamic-client packages.
Refactor constant pda seeds resolution.