Skip to content

tests: Fix expected vulnerabilities#249

Merged
afsmeira merged 1 commit intomasterfrom
am/fix-tests
Mar 6, 2026
Merged

tests: Fix expected vulnerabilities#249
afsmeira merged 1 commit intomasterfrom
am/fix-tests

Conversation

@afsmeira
Copy link
Contributor

@afsmeira afsmeira commented Mar 6, 2026

No description provided.

@afsmeira afsmeira requested a review from a team as a code owner March 6, 2026 10:46
@afsmeira afsmeira requested a review from a team March 6, 2026 10:46
@codacy-production
Copy link

Codacy's Analysis Summary

0 new issue (≤ 1 medium issue)
0 new security issue (≤ 0 issue)
More details

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes. Give us feedback

Copy link

@codacy-production codacy-production bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates test expectation files for vulnerability patterns. While the movement of CVE-2025-61730 from high to medium severity is clear, there is an unexplained change in the reported line number that could lead to test failures if not aligned with the source test data.

About this PR

  • Please provide a description for this PR. It is important to document why the severity for CVE-2025-61730 is being downgraded from high to medium and if this reflects a change in the scanning logic or an upstream database update.

Suggestions for missing tests

  • Verify that the test suite using these XML files passes with the updated line numbers and severities.
  • Confirm that the source code files (e.g., the golang/stdlib mocks) referenced by these XMLs actually contain the vulnerability on the specified lines (3 and 5 respectively).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the test suite using these XML files passes with the updated line numbers and severities.
2. Confirm that the source code files (e.g., the golang/stdlib mocks) referenced by these XMLs actually contain the vulnerability on the specified lines (3 and 5 respectively).

🗒️ Improve review quality by adding custom instructions

@afsmeira afsmeira enabled auto-merge (squash) March 6, 2026 10:52
@afsmeira afsmeira merged commit 9a764bd into master Mar 6, 2026
8 checks passed
@afsmeira afsmeira deleted the am/fix-tests branch March 6, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants