fix: replace rusb GlobalContext with explicit Context to prevent panics#191
Merged
cocool97 merged 1 commit intococool97:mainfrom Mar 30, 2026
Conversation
…nt panics rusb's GlobalContext uses Once::call_once internally, which panics if libusb_init fails (e.g. in CI servers, containers, or environments without USB support). Replace all uses with explicit rusb::Context::new() which returns a Result instead of panicking.
Contributor
Author
|
This is fixing an issue with some of my tests in CI where libusb doesn't exist. |
Owner
|
Thanks for your PR ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rusb::devices()(which internally usesGlobalContextand panics viaOnce::call_onceiflibusb_initfails) with explicitrusb::Context::new()+context.devices()which returns aResultinsteadGlobalContexttype references withContextinUSBTransportstruct and method signaturesTest plan
cargo clippypasses with no warningscargo testpasses (5 unit tests + 4 doc-tests)