Draft
Conversation
salvatorebenedetto
suggested changes
Apr 9, 2026
There was a problem hiding this comment.
This would be easier to review if split into smaller commits or separate PRs. Right now it combines: (1) the multiplexer/session refactor, (2) timeout behavior changes, and (3) dependency bumps.
More importantly, I found two blocking issues:
- TLS/STLS path never calls set_authenticated() after upgrade, so subsequent messages are routed to the wrong queue and the first command can hang or time out.
- The multiplexer thread lifecycle is unsafe: Drop can hang forever waiting on join(), and cloned sessions can also prevent cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.