-
Notifications
You must be signed in to change notification settings - Fork 477
DOC-11665: Docs for CDC/changefeeds: support protobuf as a format #22196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In changefeed-messages.md, added Protobuf section. In create-changefeed, modified format and headers_json_column_name options regarding protobuf. In changefeed-message-envelopes.md, modified envelope=enriched option regarding protobuf.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rohan-joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
taroface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I raised a style question that would mean broader changes if you agree. However, I don't feel that strongly about it.
|
✅ Cross-Version Link Check Passed All cross-version link issues have been resolved. Good job! |
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taroface thanks for the careful review.
Fixes DOC-11665
Rendered previews
formatoptionenvelope=enrichedoption