Skip to content

release-26.2: roachtest: add async association tests to activerecord ignore list#168345

Merged
trunk-io[bot] merged 1 commit intocockroachdb:release-26.2from
spilchen:blathers/backport-release-26.2-168318
Apr 14, 2026
Merged

release-26.2: roachtest: add async association tests to activerecord ignore list#168345
trunk-io[bot] merged 1 commit intocockroachdb:release-26.2from
spilchen:blathers/backport-release-26.2-168318

Conversation

@spilchen
Copy link
Copy Markdown
Contributor

@spilchen spilchen commented Apr 14, 2026

Backport 1/1 commits from #168318 on behalf of @spilchen.


The AsyncBelongsToAssociationsTest, AsyncHasManyAssociationsTest, and AsyncHasOneAssociationsTest tests all use a wait_for_async_query helper with a 5-second timeout that flakes on CI when CockroachDB query execution exceeds the deadline. These are the same class of flake as the five LoadAsyncTest entries already on the ignore list (added in d5431d9 for #162147), but the association test variants were missed at that time.

Closes: #164804
Epic: none

Release note: None


Release justification: test only fix

The `AsyncBelongsToAssociationsTest`, `AsyncHasManyAssociationsTest`, and
`AsyncHasOneAssociationsTest` tests all use a `wait_for_async_query`
helper with a 5-second timeout that flakes on CI when CockroachDB query
execution exceeds the deadline. These are the same class of flake as
the five `LoadAsyncTest` entries already on the ignore list (added in
d5431d9 for cockroachdb#162147), but the association test variants were missed
at that time.

Closes: cockroachdb#164804
Epic: none

Release note: None

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 14, 2026
@blathers-crl blathers-crl bot requested a review from bghal April 14, 2026 17:46
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 14, 2026

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io bot commented Apr 14, 2026

😎 Merged successfully - details.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Apr 14, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Apr 14, 2026
@spilchen
Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io trunk-io bot merged commit 0ffe0ba into cockroachdb:release-26.2 Apr 14, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-26.2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants