Skip to content

sql: swap CODEOWNERS between SQL Foundations and SQL Queries#168323

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
spilchen:general/260414/0953/fnd/queries-foundation-code-swap
Apr 15, 2026
Merged

sql: swap CODEOWNERS between SQL Foundations and SQL Queries#168323
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
spilchen:general/260414/0953/fnd/queries-foundation-code-swap

Conversation

@spilchen
Copy link
Copy Markdown
Contributor

This is the full ownership swap between the SQL Foundations and SQL Queries teams. IMPORT was previously moved to SQL Foundations in #167978.

Moving to SQL Queries:

  • INSPECT
  • Row-level TTL
  • Temp tables
  • Partitioning (drop partition)
  • Multi-region

Moving to SQL Foundations:

  • COPY
  • Stored procedures
  • UDFs
  • Triggers

Release note: None
Epic: none

@spilchen spilchen self-assigned this Apr 14, 2026
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io bot commented Apr 14, 2026

😎 Merged successfully - details.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 14, 2026

Detected infrastructure failure (matched: ). Automatically rerunning failed jobs. (run link)

1 similar comment
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 14, 2026

Detected infrastructure failure (matched: ). Automatically rerunning failed jobs. (run link)

This is the full ownership swap between the SQL Foundations and SQL
Queries teams. IMPORT was previously moved to SQL Foundations in cockroachdb#167978.

Moving to SQL Queries:
- INSPECT
- Row-level TTL
- Temp tables
- Partitioning (drop partition)
- Multi-region

Moving to SQL Foundations:
- COPY
- Stored procedures
- UDFs
- Triggers

Release note: None
Epic: none

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@spilchen spilchen force-pushed the general/260414/0953/fnd/queries-foundation-code-swap branch from 4fb9019 to 553a638 Compare April 14, 2026 17:03
@spilchen spilchen marked this pull request as ready for review April 14, 2026 17:39
@spilchen spilchen requested a review from a team as a code owner April 14, 2026 17:39
@spilchen spilchen requested review from a team and mw5h April 14, 2026 17:39
Copy link
Copy Markdown
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@fqazi reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on mw5h).

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 14, 2026

Metrics change detected

This PR adds or updates one or more CRDB metrics. If you want these metrics to be exported by CRDB Cloud clusters to Internal CRL Datadog and/or included in the customer metric export integration (Essential metrics for standard deployment, and Essential metrics for advanced deployment), refer to this Installation and Usage guide of a CLI tool that syncs the metric mappings in managed-service. Run this CLI tool after your CRDB PR is merged.

  • The CLI opens a PR in managed-service with the required config changes.
  • Please track that PR and ensure it merges so your metrics become available to CRDB Cloud clusters.

Note: Your metric will appear in Internal CRL Datadog only after the managed-service PR merges and the new OTel configuration rolls out to at least one cluster running a CRDB build that includes this metric.

Docs: cockroach-metric-sync

Questions: reach out to @obs-india-prs

Copy link
Copy Markdown
Contributor

@mw5h mw5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mw5h made 1 comment.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on spilchen).

@spilchen spilchen added the backport-all Flags PRs that need to be backported to all supported release branches label Apr 15, 2026
@spilchen
Copy link
Copy Markdown
Contributor Author

TFTR!

/trunk merge

@trunk-io trunk-io bot merged commit 6fbf6bf into cockroachdb:master Apr 15, 2026
31 checks passed
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 15, 2026

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


merge conflict cherry-picking 553a638 to blathers/backport-release-24.3-168323

Backport to branch release-24.3 failed. See errors above.


merge conflict cherry-picking 553a638 to blathers/backport-release-25.2-168323

Backport to branch release-25.2 failed. See errors above.


merge conflict cherry-picking 553a638 to blathers/backport-release-25.4-168323

Backport to branch release-25.4 failed. See errors above.


merge conflict cherry-picking 553a638 to blathers/backport-release-26.1-168323

Backport to branch release-26.1 failed. See errors above.


merge conflict cherry-picking 553a638 to blathers/backport-release-26.2-168323

Backport to branch release-26.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all Flags PRs that need to be backported to all supported release branches backport-failed target-release-26.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants