Add skill-dedup regression test for readiness-core - #490
Closed
shaurya703 wants to merge 1 commit into
Closed
Conversation
- Same skill directory name under two scanned roots (.grok/skills/foo and skills/foo) must be returned once by scanSkillDirectories - Distinct skill names still count separately - Documents why dedup matters for skillsOne vs skillsTwoPlus score signals Fixes cobusgreyling#480
Owner
|
Thanks for the contribution! Closing as a duplicate of the green PRs that just merged (same tests from the Wave 6 good-first-issue batch):
Your effort still matters — grab another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #480
Adds a regression test for
scanSkillDirectoriesintools/readiness-core, locking in the dedup fix from #475:.grok/skills/fooandskills/foo) is returned exactly oncebar) still count separatelyskillsOnesignal toskillsTwoPlusfor what is really a single skillFixture dirs are created and removed inside the test itself — no permanent fixtures added, matching the existing test's style.
Suite results (
cd tools/readiness-core && npm test): 4 tests, 4 pass, 0 fail.